From: Tom Tromey <tromey@adacore.com>
To: Pedro Alves <palves@redhat.com>
Cc: Tom Tromey <tromey@adacore.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix "list" when control characters are seen
Date: Tue, 18 Jun 2019 15:29:00 -0000 [thread overview]
Message-ID: <87lfxylxnw.fsf@tromey.com> (raw)
In-Reply-To: <32fe2c91-99f5-5b2a-ccaa-8481b1747dd5@redhat.com> (Pedro Alves's message of "Tue, 18 Jun 2019 14:24:17 +0100")
>> static void foo (int x)
>> /* !
>> - !
>> +
Pedro> This seems pretty obscure without the context of the patch around.
Pedro> Should we add a comment here?
Good idea, how's this?
Tom
commit d20ed5fd574ce1b72543c2963fa53946eb2225de
Author: Tom Tromey <tromey@adacore.com>
Date: Tue Jun 18 09:27:45 2019 -0600
Add comment to list0.h
Pedro suggested adding a comment to list0.h to explain the control
character.
Tested on x86-64 Fedora 29.
gdb/testsuite/ChangeLog
2019-06-18 Tom Tromey <tromey@adacore.com>
* gdb.base/list0.h: Add comment explaining control character.
diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index b6fcf58c7dd..75adad35f48 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,3 +1,7 @@
+2019-06-18 Tom Tromey <tromey@adacore.com>
+
+ * gdb.base/list0.h: Add comment explaining control character.
+
2019-06-18 Tom de Vries <tdevries@suse.de>
* boards/fission.exp: Break up long debug_flags line.
diff --git a/gdb/testsuite/gdb.base/list0.h b/gdb/testsuite/gdb.base/list0.h
index 6f280935509..ba18e29268e 100644
--- a/gdb/testsuite/gdb.base/list0.h
+++ b/gdb/testsuite/gdb.base/list0.h
@@ -2,7 +2,7 @@
extern void bar(int);
static void foo (int x)
-/* !
+/* ! the next line has a control character, see PR symtab/24423.
\f
! */
{
next prev parent reply other threads:[~2019-06-18 15:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-09 18:54 Tom Tromey
2019-04-09 19:24 ` Andreas Schwab
2019-04-10 16:53 ` Tom Tromey
2019-04-19 19:03 ` Tom Tromey
2019-06-18 13:24 ` Pedro Alves
2019-06-18 15:29 ` Tom Tromey [this message]
2019-06-18 15:33 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lfxylxnw.fsf@tromey.com \
--to=tromey@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox