From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-156863-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 47753 invoked by alias); 18 Jun 2019 15:33:58 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 47745 invoked by uid 89); 18 Jun 2019 15:33:57 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy=HX-Languages-Length:327
X-HELO: mail-wm1-f45.google.com
Received: from mail-wm1-f45.google.com (HELO mail-wm1-f45.google.com) (209.85.128.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 18 Jun 2019 15:33:56 +0000
Received: by mail-wm1-f45.google.com with SMTP id s3so3819356wms.2        for <gdb-patches@sourceware.org>; Tue, 18 Jun 2019 08:33:56 -0700 (PDT)
Return-Path: <palves@redhat.com>
Received: from ?IPv6:2001:8a0:f913:f700:56ee:75ff:fe8d:232b? ([2001:8a0:f913:f700:56ee:75ff:fe8d:232b])        by smtp.gmail.com with ESMTPSA id p26sm9320278wrp.58.2019.06.18.08.33.53        (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128);        Tue, 18 Jun 2019 08:33:53 -0700 (PDT)
Subject: Re: [PATCH] Fix "list" when control characters are seen
To: Tom Tromey <tromey@adacore.com>
References: <20190409185432.16985-1-tromey@adacore.com> <32fe2c91-99f5-5b2a-ccaa-8481b1747dd5@redhat.com> <87lfxylxnw.fsf@tromey.com>
Cc: gdb-patches@sourceware.org
From: Pedro Alves <palves@redhat.com>
Message-ID: <86175428-7135-14e2-600d-7952a0064750@redhat.com>
Date: Tue, 18 Jun 2019 15:33:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1
MIME-Version: 1.0
In-Reply-To: <87lfxylxnw.fsf@tromey.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-SW-Source: 2019-06/txt/msg00337.txt.bz2

On 6/18/19 4:29 PM, Tom Tromey wrote:
>>> static void foo (int x)
>>> /* !
>>> -   !
>>> +
> 
> Pedro> This seems pretty obscure without the context of the patch around.
> 
> Pedro> Should we add a comment here?
> 
> Good idea, how's this?

Looks great, thanks.

Pedro Alves