From: Pedro Alves <pedro@palves.net>
To: Simon Marchi <simon.marchi@polymtl.ca>, gdb-patches@sourceware.org
Cc: Scott.Linder@amd.com, Zoran.Zaric@amd.com
Subject: Re: [PATCH v2 0/3] Support frames inlined in outer frames
Date: Thu, 27 Aug 2020 22:44:50 +0100 [thread overview]
Message-ID: <8553bf1c-256a-5c39-9e2b-19f47c628b84@palves.net> (raw)
In-Reply-To: <20200827205724.409603-1-simon.marchi@polymtl.ca>
On 8/27/20 9:57 PM, Simon Marchi via Gdb-patches wrote:
> This is essentially a v2 of this thread here:
>
> https://sourceware.org/pipermail/gdb-patches/2020-March/166786.html
>
> In summary, this is what the patches do:
>
> 1. fixes a latent bug that triggered when trying to unwind a frame
> inlined in the outer frame
> 2. changes how outer frames are represented
> 3. allows frames inlined in outer frames, adds a test that runs on
> regular hardware
>
> I don't see any regression on x86-64. I tested previous iterations of
> the series (with similar code) on aarch64 too and didn't see any
> regression.
This all LGTM. Feel free to push with the nits I pointed out on
patches #1 and #2 addressed.
For the record, I was involved in discussions about this with Simon and
the AMD folks as this went through multiple potential solutions before
settling here. I think this ended up being quite nice and clean.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2020-08-27 21:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-27 20:57 Simon Marchi
2020-08-27 20:57 ` [PATCH v2 1/3] gdb: make frame_unwind_got_optimized return a not_lval value Simon Marchi
2020-08-27 21:37 ` Pedro Alves
2020-08-27 20:57 ` [PATCH v2 2/3] gdb: introduce explicit outer frame id kind Simon Marchi
2020-08-27 21:38 ` Pedro Alves
2020-08-27 20:57 ` [PATCH v2 3/3] gdb: support frames inlined into the outer frame Simon Marchi
2020-09-08 9:55 ` [committed][gdb/testsuite] Fix gdb.dwarf2/frame-inlined-in-outer-frame.exp Tom de Vries
2020-08-27 21:44 ` Pedro Alves [this message]
2020-08-28 8:50 ` [PATCH v2 0/3] Support frames inlined in outer frames Andrew Burgess
2020-08-31 17:32 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8553bf1c-256a-5c39-9e2b-19f47c628b84@palves.net \
--to=pedro@palves.net \
--cc=Scott.Linder@amd.com \
--cc=Zoran.Zaric@amd.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox