Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Simon Marchi <simon.marchi@polymtl.ca>
To: gdb-patches@sourceware.org
Cc: Zoran.Zaric@amd.com, Tony.Tye@amd.com, Scott.Linder@amd.com,
	Simon Marchi <simon.marchi@polymtl.ca>
Subject: [PATCH v2 0/3] Support frames inlined in outer frames
Date: Thu, 27 Aug 2020 16:57:21 -0400	[thread overview]
Message-ID: <20200827205724.409603-1-simon.marchi@polymtl.ca> (raw)

This is essentially a v2 of this thread here:

    https://sourceware.org/pipermail/gdb-patches/2020-March/166786.html

In summary, this is what the patches do:

1. fixes a latent bug that triggered when trying to unwind a frame
   inlined in the outer frame
2. changes how outer frames are represented
3. allows frames inlined in outer frames, adds a test that runs on
   regular hardware

I don't see any regression on x86-64.  I tested previous iterations of
the series (with similar code) on aarch64 too and didn't see any
regression.

Scott Linder (1):
  gdb: support frames inlined into the outer frame

Simon Marchi (2):
  gdb: make frame_unwind_got_optimized return a not_lval value
  gdb: introduce explicit outer frame id kind

 gdb/frame-unwind.c                            |  14 +-
 gdb/frame-unwind.h                            |   3 +
 gdb/frame.c                                   |  21 +--
 gdb/frame.h                                   |   9 +-
 gdb/inline-frame.c                            |   4 -
 .../gdb.dwarf2/dw2-reg-undefined.exp          |  12 ++
 .../gdb.dwarf2/frame-inlined-in-outer-frame.S | 137 ++++++++++++++++++
 .../frame-inlined-in-outer-frame.exp          | 114 +++++++++++++++
 8 files changed, 281 insertions(+), 33 deletions(-)
 create mode 100644 gdb/testsuite/gdb.dwarf2/frame-inlined-in-outer-frame.S
 create mode 100644 gdb/testsuite/gdb.dwarf2/frame-inlined-in-outer-frame.exp

-- 
2.28.0



             reply	other threads:[~2020-08-27 20:57 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-27 20:57 Simon Marchi [this message]
2020-08-27 20:57 ` [PATCH v2 1/3] gdb: make frame_unwind_got_optimized return a not_lval value Simon Marchi
2020-08-27 21:37   ` Pedro Alves
2020-08-27 20:57 ` [PATCH v2 2/3] gdb: introduce explicit outer frame id kind Simon Marchi
2020-08-27 21:38   ` Pedro Alves
2020-08-27 20:57 ` [PATCH v2 3/3] gdb: support frames inlined into the outer frame Simon Marchi
2020-09-08  9:55   ` [committed][gdb/testsuite] Fix gdb.dwarf2/frame-inlined-in-outer-frame.exp Tom de Vries
2020-08-27 21:44 ` [PATCH v2 0/3] Support frames inlined in outer frames Pedro Alves
2020-08-28  8:50 ` Andrew Burgess
2020-08-31 17:32   ` Simon Marchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200827205724.409603-1-simon.marchi@polymtl.ca \
    --to=simon.marchi@polymtl.ca \
    --cc=Scott.Linder@amd.com \
    --cc=Tony.Tye@amd.com \
    --cc=Zoran.Zaric@amd.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox