From: Pedro Alves <pedro@palves.net>
To: Simon Marchi <simon.marchi@polymtl.ca>, gdb-patches@sourceware.org
Cc: Scott.Linder@amd.com, Simon Marchi <simon.marchi@efficios.com>,
Zoran.Zaric@amd.com
Subject: Re: [PATCH v2 2/3] gdb: introduce explicit outer frame id kind
Date: Thu, 27 Aug 2020 22:38:26 +0100 [thread overview]
Message-ID: <6a2779a9-e62b-f74d-ecaf-bcc4cff1a5e8@palves.net> (raw)
In-Reply-To: <20200827205724.409603-3-simon.marchi@polymtl.ca>
On 8/27/20 9:57 PM, Simon Marchi via Gdb-patches wrote:
> - else if (l.stack_status == FID_STACK_INVALID
> + if (l.stack_status == FID_STACK_INVALID
> || r.stack_status == FID_STACK_INVALID)
The indentation of that second line in the predicate should be
fixed, I think.
next prev parent reply other threads:[~2020-08-27 21:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-27 20:57 [PATCH v2 0/3] Support frames inlined in outer frames Simon Marchi
2020-08-27 20:57 ` [PATCH v2 1/3] gdb: make frame_unwind_got_optimized return a not_lval value Simon Marchi
2020-08-27 21:37 ` Pedro Alves
2020-08-27 20:57 ` [PATCH v2 2/3] gdb: introduce explicit outer frame id kind Simon Marchi
2020-08-27 21:38 ` Pedro Alves [this message]
2020-08-27 20:57 ` [PATCH v2 3/3] gdb: support frames inlined into the outer frame Simon Marchi
2020-09-08 9:55 ` [committed][gdb/testsuite] Fix gdb.dwarf2/frame-inlined-in-outer-frame.exp Tom de Vries
2020-08-27 21:44 ` [PATCH v2 0/3] Support frames inlined in outer frames Pedro Alves
2020-08-28 8:50 ` Andrew Burgess
2020-08-31 17:32 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6a2779a9-e62b-f74d-ecaf-bcc4cff1a5e8@palves.net \
--to=pedro@palves.net \
--cc=Scott.Linder@amd.com \
--cc=Zoran.Zaric@amd.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@efficios.com \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox