From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by sourceware.org (Postfix) with ESMTPS id 9F0EA3857C49 for ; Thu, 27 Aug 2020 21:38:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 9F0EA3857C49 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=alves.ped@gmail.com Received: by mail-wr1-f68.google.com with SMTP id b18so6691929wrs.7 for ; Thu, 27 Aug 2020 14:38:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=1zFjLgPz/J7MMaKatLvAPXDFa1S7DndjyV/4WFbq2js=; b=rnnEH1i95RP6wMC1TfmT15vvgYN/FdWdfGm0Rv+C1+7HVVHupofDEBotjEEv+Cu4cG gAhTApgnx2Rh51AqoKTvbaiuw92Kd3YadsNr6m8AtIapgI6LBc7PXAkT9FIfwt5WLAue kMeFffm7emfA9eWdZekzhpuF8gA2J7FNjBRDrv8zvGkZagf9nG6f5ASaPIpJ9B0OsFAS GTWx0BMysuFoKLHtFGKCDghUVapq/lKFtNiQehLuKL03q0egB5UoGoorN/AfELGmXHUK /0jgeM6tqCoa+2uKT4FQ7GRMHT3VtUwh9j9pzb9W6xVGUNhm1VmOPKMUo1ETAW9mNQ8B 5pRw== X-Gm-Message-State: AOAM531sWax3fqWtSohhPTDLl/T8qmRqr+ROnLq2bKeasp4je6WzHPF2 Q8OMe7zAXOLh5PT5P+1Q6vQ= X-Google-Smtp-Source: ABdhPJwtErBL1qGJwCHTy8ywClrlzEESSDnzzzgs7fxBLtc7T99gXhonwXdVhSCTRk3s8L50e5AB+A== X-Received: by 2002:adf:f101:: with SMTP id r1mr3367145wro.314.1598564308785; Thu, 27 Aug 2020 14:38:28 -0700 (PDT) Received: from ?IPv6:2001:8a0:f905:5600:56ee:75ff:fe8d:232b? ([2001:8a0:f905:5600:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id o66sm7912755wmb.27.2020.08.27.14.38.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 27 Aug 2020 14:38:27 -0700 (PDT) Subject: Re: [PATCH v2 2/3] gdb: introduce explicit outer frame id kind To: Simon Marchi , gdb-patches@sourceware.org References: <20200827205724.409603-1-simon.marchi@polymtl.ca> <20200827205724.409603-3-simon.marchi@polymtl.ca> Cc: Scott.Linder@amd.com, Simon Marchi , Zoran.Zaric@amd.com From: Pedro Alves Message-ID: <6a2779a9-e62b-f74d-ecaf-bcc4cff1a5e8@palves.net> Date: Thu, 27 Aug 2020 22:38:26 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20200827205724.409603-3-simon.marchi@polymtl.ca> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Aug 2020 21:38:30 -0000 On 8/27/20 9:57 PM, Simon Marchi via Gdb-patches wrote: > - else if (l.stack_status == FID_STACK_INVALID > + if (l.stack_status == FID_STACK_INVALID > || r.stack_status == FID_STACK_INVALID) The indentation of that second line in the predicate should be fixed, I think.