From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from barracuda.ebox.ca (barracuda.ebox.ca [96.127.255.19]) by sourceware.org (Postfix) with ESMTPS id 9C9E03877028 for ; Thu, 27 Aug 2020 20:57:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 9C9E03877028 X-ASG-Debug-ID: 1598561845-0c856e180d6536b0001-fS2M51 Received: from smtp.ebox.ca (smtp.ebox.ca [96.127.255.82]) by barracuda.ebox.ca with ESMTP id I9eXexhWaKLK0lLN (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 27 Aug 2020 16:57:25 -0400 (EDT) X-Barracuda-Envelope-From: simon.marchi@polymtl.ca X-Barracuda-RBL-Trusted-Forwarder: 96.127.255.82 Received: from simark.localdomain (173-246-6-90.qc.cable.ebox.net [173.246.6.90]) by smtp.ebox.ca (Postfix) with ESMTP id 7906D441D64; Thu, 27 Aug 2020 16:57:25 -0400 (EDT) From: Simon Marchi X-Barracuda-RBL-IP: 173.246.6.90 X-Barracuda-Effective-Source-IP: 173-246-6-90.qc.cable.ebox.net[173.246.6.90] X-Barracuda-Apparent-Source-IP: 173.246.6.90 To: gdb-patches@sourceware.org Cc: Zoran.Zaric@amd.com, Tony.Tye@amd.com, Scott.Linder@amd.com, Simon Marchi Subject: [PATCH v2 0/3] Support frames inlined in outer frames Date: Thu, 27 Aug 2020 16:57:21 -0400 X-ASG-Orig-Subj: [PATCH v2 0/3] Support frames inlined in outer frames Message-Id: <20200827205724.409603-1-simon.marchi@polymtl.ca> X-Mailer: git-send-email 2.28.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Barracuda-Connect: smtp.ebox.ca[96.127.255.82] X-Barracuda-Start-Time: 1598561845 X-Barracuda-Encrypted: DHE-RSA-AES256-SHA X-Barracuda-URL: https://96.127.255.19:443/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at ebox.ca X-Barracuda-Scan-Msg-Size: 1472 X-Barracuda-BRTS-Status: 1 X-Barracuda-Spam-Score: 0.00 X-Barracuda-Spam-Status: No, SCORE=0.00 using global scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=8.0 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.3.84209 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Spam-Status: No, score=-8.1 required=5.0 tests=BAYES_00, KAM_DMARC_QUARANTINE, KAM_DMARC_STATUS, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_SOFTFAIL, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Aug 2020 20:57:42 -0000 This is essentially a v2 of this thread here: https://sourceware.org/pipermail/gdb-patches/2020-March/166786.html In summary, this is what the patches do: 1. fixes a latent bug that triggered when trying to unwind a frame inlined in the outer frame 2. changes how outer frames are represented 3. allows frames inlined in outer frames, adds a test that runs on regular hardware I don't see any regression on x86-64. I tested previous iterations of the series (with similar code) on aarch64 too and didn't see any regression. Scott Linder (1): gdb: support frames inlined into the outer frame Simon Marchi (2): gdb: make frame_unwind_got_optimized return a not_lval value gdb: introduce explicit outer frame id kind gdb/frame-unwind.c | 14 +- gdb/frame-unwind.h | 3 + gdb/frame.c | 21 +-- gdb/frame.h | 9 +- gdb/inline-frame.c | 4 - .../gdb.dwarf2/dw2-reg-undefined.exp | 12 ++ .../gdb.dwarf2/frame-inlined-in-outer-frame.S | 137 ++++++++++++++++++ .../frame-inlined-in-outer-frame.exp | 114 +++++++++++++++ 8 files changed, 281 insertions(+), 33 deletions(-) create mode 100644 gdb/testsuite/gdb.dwarf2/frame-inlined-in-outer-frame.S create mode 100644 gdb/testsuite/gdb.dwarf2/frame-inlined-in-outer-frame.exp -- 2.28.0