From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by sourceware.org (Postfix) with ESMTPS id 029173857C44 for ; Thu, 27 Aug 2020 21:44:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 029173857C44 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=alves.ped@gmail.com Received: by mail-wr1-f68.google.com with SMTP id b18so6703488wrs.7 for ; Thu, 27 Aug 2020 14:44:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Pj5UEQHUPwf9ptBw5TO+d7KyDlT0paTgwAUFbH0yu5Q=; b=dQOwrs2zw5Jpxfjvg4ogB8vbd+E0/QxABZUISDgXLfDzA5RSwmBb65S4wRtZqMGbex Mx1yewqqUWgleqM4NssZrHyIsOqcBarghzKxsTH+PB/7RTFyxxX9Gd3VHeD3VVx9hLZb SoisxR4xByV5DJdff4pyV+g9sDixc80dtJUksQUgNQS2kTOrGfOrWpTr5iOnL3+MzKO3 bR/NZIs8MymmQiFlD+YZ69LGpe6nwwZmMGchQVUmjoYY9NaG/SSVYwM0Y0I510B9Kx1l z1e0tIWwpPON7v8X8sZzzddvMzos4QemKh7Oe61PRWF0dNk+JrOJ5CzzrAlVZ+5o6/4e SprA== X-Gm-Message-State: AOAM530S/QsaHrX0mWERW1HFUgL5hR7U2bKTrDANJ8ZrIBodbpeYDSCS /63OFBqddfSTFslGXcnCYeM= X-Google-Smtp-Source: ABdhPJx+QT6IE1+f1veN/TEg2ak81D2QL5WmnYBKxWd0un+56a3h2jZFeqF0TMRMd3A3B9IDP18bSA== X-Received: by 2002:a5d:4f12:: with SMTP id c18mr4542763wru.33.1598564695101; Thu, 27 Aug 2020 14:44:55 -0700 (PDT) Received: from ?IPv6:2001:8a0:f905:5600:56ee:75ff:fe8d:232b? ([2001:8a0:f905:5600:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id c6sm7841645wrr.15.2020.08.27.14.44.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 27 Aug 2020 14:44:54 -0700 (PDT) Subject: Re: [PATCH v2 0/3] Support frames inlined in outer frames To: Simon Marchi , gdb-patches@sourceware.org References: <20200827205724.409603-1-simon.marchi@polymtl.ca> Cc: Scott.Linder@amd.com, Zoran.Zaric@amd.com From: Pedro Alves Message-ID: <8553bf1c-256a-5c39-9e2b-19f47c628b84@palves.net> Date: Thu, 27 Aug 2020 22:44:50 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20200827205724.409603-1-simon.marchi@polymtl.ca> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Aug 2020 21:44:57 -0000 On 8/27/20 9:57 PM, Simon Marchi via Gdb-patches wrote: > This is essentially a v2 of this thread here: > > https://sourceware.org/pipermail/gdb-patches/2020-March/166786.html > > In summary, this is what the patches do: > > 1. fixes a latent bug that triggered when trying to unwind a frame > inlined in the outer frame > 2. changes how outer frames are represented > 3. allows frames inlined in outer frames, adds a test that runs on > regular hardware > > I don't see any regression on x86-64. I tested previous iterations of > the series (with similar code) on aarch64 too and didn't see any > regression. This all LGTM. Feel free to push with the nits I pointed out on patches #1 and #2 addressed. For the record, I was involved in discussions about this with Simon and the AMD folks as this went through multiple potential solutions before settling here. I think this ended up being quite nice and clean. Thanks, Pedro Alves