From: Eli Zaretskii <eliz@gnu.org>
To: Andrew Burgess <andrew.burgess@embecosm.com>
Cc: gdb-patches@sourceware.org, palves@redhat.com
Subject: Re: [PATCH 7/7] gdb: Extend help text for 'list' command.
Date: Thu, 10 Dec 2015 16:24:00 -0000 [thread overview]
Message-ID: <83y4d29sr6.fsf@gnu.org> (raw)
In-Reply-To: <20151210100755.GA11555@embecosm.com>
> Date: Thu, 10 Dec 2015 10:07:55 +0000
> From: Andrew Burgess <andrew.burgess@embecosm.com>
> Cc: Pedro Alves <palves@redhat.com>
>
> * Pedro Alves <palves@redhat.com> [2015-11-26 12:38:41 +0000]:
>
> > LGTM, but probably Eli should take a look.
>
> Eli, any feedback?
Some, see below.
> @@ -1901,7 +1901,11 @@ Lines can be specified in these ways:\n\
> FILE:FUNCTION, to distinguish among like-named static functions.\n\
> *ADDRESS, to list around the line containing that address.\n\
> With two args if one is empty it stands for ten lines away from \
> -the other arg."));
> +the other arg.\n\
> +\n\
> +By default when a single location is given list displays ten lines,\n\
> +this can be changed using \"set listsize\", and the current value\n\
> +shown by using \"show listsize\"."));
Some commas are missing here, which makes this difficult to read.
Suggest to fix as follows:
With two args, if one is empty, it stands for ten lines away from
the other arg.
By default, when a single location is given, display ten lines.
This can be changed using "set listsize", and the current value
can be shown using "show listsize".
Thanks.
next prev parent reply other threads:[~2015-12-10 16:24 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-25 0:34 [PATCH 0/7] Minor changes to " Andrew Burgess
2015-11-25 0:34 ` [PATCH 6/7] gdb: Add an error when 'list -' reaches the start of a file Andrew Burgess
2015-11-26 12:38 ` Pedro Alves
2015-11-25 0:34 ` [PATCH 2/7] gdb: Use NULL instead of 0 for pointer comparison Andrew Burgess
2015-11-26 12:37 ` Pedro Alves
2015-11-25 0:34 ` [PATCH 5/7] gdb: 'list' command, tweak handling of +/- arguments Andrew Burgess
2015-11-26 12:38 ` Pedro Alves
2015-11-25 0:34 ` [PATCH 3/7] gdb: Small code restructure for list_command Andrew Burgess
2015-11-26 12:37 ` Pedro Alves
2015-11-25 0:34 ` [PATCH 1/7] gdb: Make lines_to_list variable static Andrew Burgess
2015-11-26 12:37 ` Pedro Alves
2015-11-25 0:34 ` [PATCH 4/7] gdb: Make test names unique in list.exp Andrew Burgess
2015-11-26 12:37 ` Pedro Alves
2015-11-25 0:34 ` [PATCH 7/7] gdb: Extend help text for 'list' command Andrew Burgess
2015-11-26 12:38 ` Pedro Alves
2015-12-10 10:08 ` Andrew Burgess
2015-12-10 16:24 ` Eli Zaretskii [this message]
2015-12-11 23:28 ` [PATCH 0/7] Minor changes to " Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83y4d29sr6.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox