Re: [PATCH 3/7] gdb: Small code restructure for list_command.

[Pedro Alves <palves@redhat.com>]

On 11/25/2015 12:34 AM, Andrew Burgess wrote:
> Move handling of special +/- arguments to the list_command function
> inside a single if block, this helps group all related functionality
> together.  There should be no user visible changes after this commit.
> 
> gdb/ChangeLog:
> 
> 	* cli/cli-cmds.c (list_command): Move all handling of +/-
> 	arguments into a single if block.

OK.

> +      if (arg == NULL || strcmp (arg, "+") == 0)
> +	{
> +	  print_source_lines (cursal.symtab, cursal.line,
> +			      cursal.line + get_lines_to_list (), 0);
> +	  return;
> +	}
>  

...

> +      if (strcmp (arg, "-") == 0)
> +	{
> +	  print_source_lines (cursal.symtab,
> +			      max (get_first_line_listed ()
> +				   - get_lines_to_list (), 1),
> +			      get_first_line_listed (), 0);
> +	  return;
> +	}
>      }

(Seems to me you could hoist the returns out now.)

Thanks,
Pedro Alves