Re: [PATCH 5/7] gdb: 'list' command, tweak handling of +/- arguments.

Pedro Alves
2015-11-26T12:38:03Z

On 11/25/2015 12:34 AM, Andrew Burgess wrote:

> gdb/ChangeLog:
>
> * cli/cli-cmds.c (list_command): Check that the argument string is
> a single character, either '+' or '-'.
>
> gdb/testsuite/ChangeLog:
>
> * gdb.base/list.exp (test_list_invalid_args): New function,
> defined, and called.

> + clean_restart ${binfile}
> + gdb_test "list -INVALID" \
> + "invalid explicit location argument, \"-INVALID\"" \
> + "First use of \"list -INVALID\""
> + gdb_test "list -INVALID" \
> + "invalid explicit location argument, \"-INVALID\"" \
> + "Second use of \"list -INVALID\""

Nit: please use lowercase in test messages like mostly
everywhere else (including this file).

OK with that fixed.

Thanks,
Pedro Alves