Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andrew Burgess <andrew.burgess@embecosm.com>
To: gdb-patches@sourceware.org
Cc: Andrew Burgess <andrew.burgess@embecosm.com>
Subject: [PATCH 2/7] gdb: Use NULL instead of 0 for pointer comparison.
Date: Wed, 25 Nov 2015 00:34:00 -0000	[thread overview]
Message-ID: <ca67590dc936ca9fb3290a5352adbbd0b20004ff.1448411121.git.andrew.burgess@embecosm.com> (raw)
In-Reply-To: <cover.1448411121.git.andrew.burgess@embecosm.com>
In-Reply-To: <cover.1448411121.git.andrew.burgess@embecosm.com>

Small code cleanup, use NULL instead of 0 when checking pointers.  There
should be no user visible changes after this commit.

gdb/ChangeLog:

	* cli/cli-cmds.c (list_command): Use NULL instead of 0 when
	checking pointers.
---
 gdb/ChangeLog      | 5 +++++
 gdb/cli/cli-cmds.c | 4 ++--
 2 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index d1e6cbf..9c22a9a 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,10 @@
 2015-11-24  Andrew Burgess  <andrew.burgess@embecosm.com>
 
+	* cli/cli-cmds.c (list_command): Use NULL instead of 0 when
+	checking pointers.
+
+2015-11-24  Andrew Burgess  <andrew.burgess@embecosm.com>
+
 	* source.c (lines_to_list): Make static.
 
 2015-11-23  Simon Marchi  <simon.marchi@ericsson.com>
diff --git a/gdb/cli/cli-cmds.c b/gdb/cli/cli-cmds.c
index 1886cae..841fc55 100644
--- a/gdb/cli/cli-cmds.c
+++ b/gdb/cli/cli-cmds.c
@@ -907,7 +907,7 @@ list_command (char *arg, int from_tty)
   cleanup = make_cleanup (null_cleanup, NULL);
 
   /* Pull in the current default source line if necessary.  */
-  if (arg == 0 || arg[0] == '+' || arg[0] == '-')
+  if (arg == NULL || arg[0] == '+' || arg[0] == '-')
     {
       set_default_source_symtab_and_line ();
       cursal = get_current_source_symtab_and_line ();
@@ -936,7 +936,7 @@ list_command (char *arg, int from_tty)
 
   /* "l" or "l +" lists next ten lines.  */
 
-  if (arg == 0 || strcmp (arg, "+") == 0)
+  if (arg == NULL || strcmp (arg, "+") == 0)
     {
       print_source_lines (cursal.symtab, cursal.line,
 			  cursal.line + get_lines_to_list (), 0);
-- 
2.5.1


  parent reply	other threads:[~2015-11-25  0:34 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-25  0:34 [PATCH 0/7] Minor changes to 'list' command Andrew Burgess
2015-11-25  0:34 ` [PATCH 1/7] gdb: Make lines_to_list variable static Andrew Burgess
2015-11-26 12:37   ` Pedro Alves
2015-11-25  0:34 ` [PATCH 4/7] gdb: Make test names unique in list.exp Andrew Burgess
2015-11-26 12:37   ` Pedro Alves
2015-11-25  0:34 ` [PATCH 3/7] gdb: Small code restructure for list_command Andrew Burgess
2015-11-26 12:37   ` Pedro Alves
2015-11-25  0:34 ` [PATCH 7/7] gdb: Extend help text for 'list' command Andrew Burgess
2015-11-26 12:38   ` Pedro Alves
2015-12-10 10:08     ` Andrew Burgess
2015-12-10 16:24       ` Eli Zaretskii
2015-11-25  0:34 ` Andrew Burgess [this message]
2015-11-26 12:37   ` [PATCH 2/7] gdb: Use NULL instead of 0 for pointer comparison Pedro Alves
2015-11-25  0:34 ` [PATCH 6/7] gdb: Add an error when 'list -' reaches the start of a file Andrew Burgess
2015-11-26 12:38   ` Pedro Alves
2015-11-25  0:34 ` [PATCH 5/7] gdb: 'list' command, tweak handling of +/- arguments Andrew Burgess
2015-11-26 12:38   ` Pedro Alves
2015-12-11 23:28 ` [PATCH 0/7] Minor changes to 'list' command Andrew Burgess

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ca67590dc936ca9fb3290a5352adbbd0b20004ff.1448411121.git.andrew.burgess@embecosm.com \
    --to=andrew.burgess@embecosm.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox