From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-128027-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 30621 invoked by alias); 10 Dec 2015 16:24:30 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 30454 invoked by uid 89); 10 Dec 2015 16:24:21 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_FAIL autolearn=no version=3.3.2
X-HELO: mtaout20.012.net.il
Received: from mtaout20.012.net.il (HELO mtaout20.012.net.il) (80.179.55.166) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 10 Dec 2015 16:24:17 +0000
Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0NZ500K00HFU1J00@a-mtaout20.012.net.il> for gdb-patches@sourceware.org; Thu, 10 Dec 2015 18:24:09 +0200 (IST)
Received: from HOME-C4E4A596F7 ([84.94.185.246]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NZ500JEKHK9XI30@a-mtaout20.012.net.il>; Thu, 10 Dec 2015 18:24:09 +0200 (IST)
Date: Thu, 10 Dec 2015 16:24:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [PATCH 7/7] gdb: Extend help text for 'list' command.
In-reply-to: <20151210100755.GA11555@embecosm.com>
To: Andrew Burgess <andrew.burgess@embecosm.com>
Cc: gdb-patches@sourceware.org, palves@redhat.com
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83y4d29sr6.fsf@gnu.org>
References: <cover.1448411121.git.andrew.burgess@embecosm.com> <fa223534db62cd3498cad0998da452207a61bbe0.1448411122.git.andrew.burgess@embecosm.com> <5656FD51.10804@redhat.com> <20151210100755.GA11555@embecosm.com>
X-IsSubscribed: yes
X-SW-Source: 2015-12/txt/msg00197.txt.bz2

> Date: Thu, 10 Dec 2015 10:07:55 +0000
> From: Andrew Burgess <andrew.burgess@embecosm.com>
> Cc: Pedro Alves <palves@redhat.com>
> 
> * Pedro Alves <palves@redhat.com> [2015-11-26 12:38:41 +0000]:
> 
> > LGTM, but probably Eli should take a look.
> 
> Eli, any feedback?

Some, see below.

> @@ -1901,7 +1901,11 @@ Lines can be specified in these ways:\n\
>    FILE:FUNCTION, to distinguish among like-named static functions.\n\
>    *ADDRESS, to list around the line containing that address.\n\
>  With two args if one is empty it stands for ten lines away from \
> -the other arg."));
> +the other arg.\n\
> +\n\
> +By default when a single location is given list displays ten lines,\n\
> +this can be changed using \"set listsize\", and the current value\n\
> +shown by using \"show listsize\"."));

Some commas are missing here, which makes this difficult to read.
Suggest to fix as follows:

  With two args, if one is empty, it stands for ten lines away from
  the other arg.

  By default, when a single location is given, display ten lines.
  This can be changed using "set listsize", and the current value
  can be shown using "show listsize".

Thanks.