Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: gdb-patches@sourceware.org
Subject: Re: [RFA] windows-nat.c: Cygwin: Port to Cygwin 1.7
Date: Sun, 28 Feb 2010 18:56:00 -0000	[thread overview]
Message-ID: <83tyt1b35h.fsf@gnu.org> (raw)
In-Reply-To: <20100228180133.GN5683@calimero.vinschen.de>

> Date: Sun, 28 Feb 2010 19:01:33 +0100
> From: Corinna Vinschen <vinschen@redhat.com>
> 
> > > PATH_MAX, 4K, is more than enough especially since the names of DLLs
> > > are stored in a buffer which is restricted to SO_NAME_MAX_PATH_SIZE,
> > > which is 512 bytes ATM.
> > 
> > I wasn't thinking about DLL names, I was thinking about source file
> > names and names of executable programs.
> 
> The filename of executable and source files is not restricted to
> PATH_MAX.  The code in windows-nat.c only handles DLLs.  Otherwise, see
> utils.c, functions xfullpath() and gdb_realpath().  Cygwin provides the
> canonicalize_file_name function.

In that case, how about a comment explaining the limitation of
SO_NAME_MAX_PATH_SIZE somewhere ion windows-nat.c, and how PATH_MAX
does not limit that?


  reply	other threads:[~2010-02-28 18:56 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-28 15:09 Corinna Vinschen
2010-02-28 16:56 ` Pierre Muller
2010-02-28 17:09   ` Corinna Vinschen
2010-02-28 17:08 ` Eli Zaretskii
2010-02-28 17:18   ` Corinna Vinschen
2010-02-28 17:49     ` Eli Zaretskii
2010-02-28 18:01       ` Corinna Vinschen
2010-02-28 18:56         ` Eli Zaretskii [this message]
2010-02-28 19:24           ` Corinna Vinschen
2010-02-28 22:30 ` Christopher Faylor
2010-03-01  9:10   ` Corinna Vinschen
2010-03-01 10:04 Roland Schwingel
2010-03-01 15:23 ` Christopher Faylor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83tyt1b35h.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox