Re: [RFA] windows-nat.c: Cygwin: Port to Cygwin 1.7

[Christopher Faylor <cgf-use-the-mailinglist-please@sourceware.org>]

On Mon, Mar 01, 2010 at 11:04:35AM +0100, Roland Schwingel wrote:
>Hi Corinna,
>
>I just came along your patch.
>
>gdb-patches-owner@sourceware.org wrote on 28.02.2010 16:08:44:
>
> > Hi,
> >
> > the below patch ports GDB to the latest Cygwin version 1.7.
>...
>When I have read that correctly this means gdb would now no longer 
>compile with cygwin 1.5?
>Here I frequently compile gdb head for both cygwin 1.5 and cygwin 1.7. 
>With your patch this would
>no longer be possible.
>
>Wouldn't it be better to encapsulate the 1.5 code and the 1.7 specific 
>code with
>an #if CYGWIN_VERSION_DLL_MAJOR >= 1007 (or something similar).
>So on compiletime the proper functions would be selected for the right 
>cygwin version.

The proper test would be for the API version not the DLL version, i.e.,

#if CYGWIN_VERSION_DLL_MAKE_COMBINED(CYGWIN_VERSION_API_MAJOR,CYGWIN_VERSION_API_MINOR) >= 181

If you want to submit a minimally invasive patch I'll consider applying it.

cgf