From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9695 invoked by alias); 1 Mar 2010 15:23:12 -0000 Received: (qmail 9678 invoked by uid 22791); 1 Mar 2010 15:23:11 -0000 X-Spam-Check-By: sourceware.org Received: from pool-173-48-46-17.bstnma.fios.verizon.net (HELO cgf.cx) (173.48.46.17) by sourceware.org (qpsmtpd/0.83/v0.83-20-g38e4449) with ESMTP; Mon, 01 Mar 2010 15:23:07 +0000 Received: from ednor.cgf.cx (ednor.casa.cgf.cx [192.168.187.5]) by cgf.cx (Postfix) with ESMTP id AB8B713C0C8; Mon, 1 Mar 2010 10:23:05 -0500 (EST) Received: by ednor.cgf.cx (Postfix, from userid 201) id 6AD122B352; Mon, 1 Mar 2010 10:23:05 -0500 (EST) Date: Mon, 01 Mar 2010 15:23:00 -0000 From: Christopher Faylor To: Roland Schwingel , gdb-patches@sourceware.org Subject: Re: [RFA] windows-nat.c: Cygwin: Port to Cygwin 1.7 Message-ID: <20100301152304.GA14332@ednor.casa.cgf.cx> Mail-Followup-To: Roland Schwingel , gdb-patches@sourceware.org References: <4B8B9133.9050706@onevision.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4B8B9133.9050706@onevision.de> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-03/txt/msg00012.txt.bz2 On Mon, Mar 01, 2010 at 11:04:35AM +0100, Roland Schwingel wrote: >Hi Corinna, > >I just came along your patch. > >gdb-patches-owner@sourceware.org wrote on 28.02.2010 16:08:44: > > > Hi, > > > > the below patch ports GDB to the latest Cygwin version 1.7. >... >When I have read that correctly this means gdb would now no longer >compile with cygwin 1.5? >Here I frequently compile gdb head for both cygwin 1.5 and cygwin 1.7. >With your patch this would >no longer be possible. > >Wouldn't it be better to encapsulate the 1.5 code and the 1.7 specific >code with >an #if CYGWIN_VERSION_DLL_MAJOR >= 1007 (or something similar). >So on compiletime the proper functions would be selected for the right >cygwin version. The proper test would be for the API version not the DLL version, i.e., #if CYGWIN_VERSION_DLL_MAKE_COMBINED(CYGWIN_VERSION_API_MAJOR,CYGWIN_VERSION_API_MINOR) >= 181 If you want to submit a minimally invasive patch I'll consider applying it. cgf