From: Roland Schwingel <roland.schwingel@onevision.de>
To: gdb-patches@sourceware.org
Subject: Re: [RFA] windows-nat.c: Cygwin: Port to Cygwin 1.7
Date: Mon, 01 Mar 2010 10:04:00 -0000 [thread overview]
Message-ID: <4B8B9133.9050706@onevision.de> (raw)
Hi Corinna,
I just came along your patch.
gdb-patches-owner@sourceware.org wrote on 28.02.2010 16:08:44:
> Hi,
>
> the below patch ports GDB to the latest Cygwin version 1.7.
...
When I have read that correctly this means gdb would now no longer
compile with cygwin 1.5?
Here I frequently compile gdb head for both cygwin 1.5 and cygwin 1.7.
With your patch this would
no longer be possible.
Wouldn't it be better to encapsulate the 1.5 code and the 1.7 specific
code with
an #if CYGWIN_VERSION_DLL_MAJOR >= 1007 (or something similar).
So on compiletime the proper functions would be selected for the right
cygwin version.
I believe there are for sure more people than me out in this world still
using cygwin 1.5 and wanting
to have a recent gdb...
Roland
next reply other threads:[~2010-03-01 10:04 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-01 10:04 Roland Schwingel [this message]
2010-03-01 15:23 ` Christopher Faylor
-- strict thread matches above, loose matches on Subject: below --
2010-02-28 15:09 Corinna Vinschen
2010-02-28 16:56 ` Pierre Muller
2010-02-28 17:09 ` Corinna Vinschen
2010-02-28 17:08 ` Eli Zaretskii
2010-02-28 17:18 ` Corinna Vinschen
2010-02-28 17:49 ` Eli Zaretskii
2010-02-28 18:01 ` Corinna Vinschen
2010-02-28 18:56 ` Eli Zaretskii
2010-02-28 19:24 ` Corinna Vinschen
2010-02-28 22:30 ` Christopher Faylor
2010-03-01 9:10 ` Corinna Vinschen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B8B9133.9050706@onevision.de \
--to=roland.schwingel@onevision.de \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox