From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7590 invoked by alias); 1 Mar 2010 10:04:44 -0000 Received: (qmail 7525 invoked by uid 22791); 1 Mar 2010 10:04:43 -0000 X-SWARE-Spam-Status: No, hits=2.2 required=5.0 tests=AWL,BAYES_00,BOTNET,RDNS_NONE X-Spam-Check-By: sourceware.org Received: from Unknown (HELO andromeda.onevision.de) (212.77.172.62) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 01 Mar 2010 10:04:39 +0000 Received: from [192.168.5.120] (kgi05104.onevision.de [192.168.5.120]) by andromeda.onevision.de (8.14.2/8.12.9/ROSCH/DDB) with ESMTP id o21A4ZWS031757 for ; Mon, 1 Mar 2010 11:04:35 +0100 Message-ID: <4B8B9133.9050706@onevision.de> Date: Mon, 01 Mar 2010 10:04:00 -0000 From: Roland Schwingel User-Agent: Thunderbird 2.0.0.23 (Windows/20090812) MIME-Version: 1.0 To: gdb-patches@sourceware.org Subject: Re: [RFA] windows-nat.c: Cygwin: Port to Cygwin 1.7 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-03/txt/msg00008.txt.bz2 Hi Corinna, I just came along your patch. gdb-patches-owner@sourceware.org wrote on 28.02.2010 16:08:44: > Hi, > > the below patch ports GDB to the latest Cygwin version 1.7. ... When I have read that correctly this means gdb would now no longer compile with cygwin 1.5? Here I frequently compile gdb head for both cygwin 1.5 and cygwin 1.7. With your patch this would no longer be possible. Wouldn't it be better to encapsulate the 1.5 code and the 1.7 specific code with an #if CYGWIN_VERSION_DLL_MAJOR >= 1007 (or something similar). So on compiletime the proper functions would be selected for the right cygwin version. I believe there are for sure more people than me out in this world still using cygwin 1.5 and wanting to have a recent gdb... Roland