From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-70537-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 31664 invoked by alias); 28 Feb 2010 18:56:09 -0000
Received: (qmail 31643 invoked by uid 22791); 28 Feb 2010 18:56:09 -0000
X-SWARE-Spam-Status: No, hits=-1.5 required=5.0 	tests=AWL,BAYES_00,SPF_SOFTFAIL
X-Spam-Check-By: sourceware.org
Received: from mtaout22.012.net.il (HELO mtaout22.012.net.il) (80.179.55.172)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 28 Feb 2010 18:56:04 +0000
Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0KYK00900F33XR00@a-mtaout22.012.net.il> for gdb-patches@sourceware.org; Sun, 28 Feb 2010 20:56:01 +0200 (IST)
Received: from HOME-C4E4A596F7 ([87.70.17.203]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0KYK004VOF9CH6D0@a-mtaout22.012.net.il> for gdb-patches@sourceware.org; Sun, 28 Feb 2010 20:56:01 +0200 (IST)
Date: Sun, 28 Feb 2010 18:56:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [RFA] windows-nat.c: Cygwin: Port to Cygwin 1.7
In-reply-to: <20100228180133.GN5683@calimero.vinschen.de>
To: gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83tyt1b35h.fsf@gnu.org>
References: <20100228150844.GH5683@calimero.vinschen.de> <837hpxcmp0.fsf@gnu.org> <20100228171828.GK5683@calimero.vinschen.de> <83wrxxb690.fsf@gnu.org> <20100228180133.GN5683@calimero.vinschen.de>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-02/txt/msg00696.txt.bz2

> Date: Sun, 28 Feb 2010 19:01:33 +0100
> From: Corinna Vinschen <vinschen@redhat.com>
> 
> > > PATH_MAX, 4K, is more than enough especially since the names of DLLs
> > > are stored in a buffer which is restricted to SO_NAME_MAX_PATH_SIZE,
> > > which is 512 bytes ATM.
> > 
> > I wasn't thinking about DLL names, I was thinking about source file
> > names and names of executable programs.
> 
> The filename of executable and source files is not restricted to
> PATH_MAX.  The code in windows-nat.c only handles DLLs.  Otherwise, see
> utils.c, functions xfullpath() and gdb_realpath().  Cygwin provides the
> canonicalize_file_name function.

In that case, how about a comment explaining the limitation of
SO_NAME_MAX_PATH_SIZE somewhere ion windows-nat.c, and how PATH_MAX
does not limit that?