From: Eli Zaretskii <eliz@gnu.org>
To: Stafford Horne <shorne@gmail.com>
Cc: gdb-patches@sourceware.org, openrisc@lists.librecores.org
Subject: Re: [PATCH v3 4/4] tdesc: handle arbitrary strings in tdesc_register_in_reggroup_p
Date: Wed, 20 Dec 2017 16:37:00 -0000 [thread overview]
Message-ID: <83r2rpo0of.fsf@gnu.org> (raw)
In-Reply-To: <20171219221300.GB32243@lianli.shorne-pla.net> (message from Stafford Horne on Wed, 20 Dec 2017 07:13:00 +0900)
> Date: Wed, 20 Dec 2017 07:13:00 +0900
> From: Stafford Horne <shorne@gmail.com>
> Cc: gdb-patches@sourceware.org, openrisc@lists.librecores.org
>
> > > @item group
> > > -The register group to which this register belongs. It must
> > > -be either @code{general}, @code{float}, or @code{vector}. If no
> > > -@var{group} is specified, @value{GDBN} will not display the register
> > > -in @code{info registers}.
> > > +The register group to which this register belongs. It can be one of the
> > > +standard register groups @code{general}, @code{float}, @code{vector} or an
> > > +arbitrary string. The string should be limited to alphanumeric characters
> > > +and internal hyphens. If no @var{group} is specified, @value{GDBN} will
> >
> > What do you mean by "internal hyphens"?
>
> This means, hyphens withing the register group name, not starting or ending with
> hyphens. (i.e. special-spr, but not rg1- or -rg2)
Then I think this text needs to be rephrased, so that it first says
what are the characters allowed in a reggroup name, and then says that
ranges of groups, with 2 group names separated by hyphens, are also
accepted.
Thanks.
next prev parent reply other threads:[~2017-12-20 16:37 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-19 14:23 [PATCH v3 0/4] Support for arbitrary reggroups Stafford Horne
2017-12-19 14:23 ` [PATCH v3 4/4] tdesc: handle arbitrary strings in tdesc_register_in_reggroup_p Stafford Horne
2017-12-19 16:27 ` Eli Zaretskii
2017-12-19 22:13 ` Stafford Horne
2017-12-20 13:35 ` Stafford Horne
2017-12-20 16:37 ` Eli Zaretskii [this message]
2017-12-21 3:29 ` Simon Marchi
2017-12-21 12:55 ` Stafford Horne
2017-12-19 14:23 ` [PATCH v3 2/4] reggroups: Convert reggroups from post_init to pre_init Stafford Horne
2017-12-21 3:03 ` Simon Marchi
2017-12-19 14:23 ` [PATCH v3 3/4] reggroups: Create reggroup_gdbarch_new for dynamic reggroups Stafford Horne
2017-12-21 3:15 ` Simon Marchi
2017-12-19 14:23 ` [PATCH v3 1/4] reggroups: Add test and docs for `info reg $reggroup` feature Stafford Horne
2017-12-19 16:23 ` Eli Zaretskii
2017-12-20 10:40 ` Stafford Horne
2017-12-21 2:40 ` Simon Marchi
2017-12-21 3:40 ` Eli Zaretskii
2017-12-21 2:59 ` Simon Marchi
2017-12-24 14:47 ` Stafford Horne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83r2rpo0of.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=openrisc@lists.librecores.org \
--cc=shorne@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox