From: Simon Marchi <simon.marchi@polymtl.ca>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Stafford Horne <shorne@gmail.com>,
gdb-patches@sourceware.org, openrisc@lists.librecores.org
Subject: Re: [PATCH v3 1/4] reggroups: Add test and docs for `info reg $reggroup` feature
Date: Thu, 21 Dec 2017 02:40:00 -0000 [thread overview]
Message-ID: <596161e11663add8b95ca70dd1f8f12b@polymtl.ca> (raw)
In-Reply-To: <837etiptz2.fsf@gnu.org>
On 2017-12-19 11:23, Eli Zaretskii wrote:
>> From: Stafford Horne <shorne@gmail.com>
>> Cc: Openrisc <openrisc@lists.librecores.org>, Stafford Horne
>> <shorne@gmail.com>
>> Date: Tue, 19 Dec 2017 23:22:54 +0900
>>
>> Until now this feature has existed but was not documented. Adding
>> docs
>> and tests.
>
> Thanks!
>
>> +@item info registers @var{reggroup} @dots{}
>> +Print the name and value of the registers in each of the specified
>> +@var{reggroup}. The @var{reggoup} can be any of those returned by
>
> Please use "@var{reggroup}s", with the trailing "s", otherwise this is
> not correct English.
>
>> +@code{maint print reggroups}.
>
> Please add here a cross-reference to the node where "maint print
> reggroups" is described.
Is it ok for a non-maint command to refer to a maint command? AFAIK, we
don't expect an average user to have to use maintenance commands when
using GDB. So maybe "maint print reggroups" should be promoted to a
non-maint command (e.g. info register-groups)?
Simon
next prev parent reply other threads:[~2017-12-21 2:40 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-19 14:23 [PATCH v3 0/4] Support for arbitrary reggroups Stafford Horne
2017-12-19 14:23 ` [PATCH v3 4/4] tdesc: handle arbitrary strings in tdesc_register_in_reggroup_p Stafford Horne
2017-12-19 16:27 ` Eli Zaretskii
2017-12-19 22:13 ` Stafford Horne
2017-12-20 13:35 ` Stafford Horne
2017-12-20 16:37 ` Eli Zaretskii
2017-12-21 3:29 ` Simon Marchi
2017-12-21 12:55 ` Stafford Horne
2017-12-19 14:23 ` [PATCH v3 2/4] reggroups: Convert reggroups from post_init to pre_init Stafford Horne
2017-12-21 3:03 ` Simon Marchi
2017-12-19 14:23 ` [PATCH v3 3/4] reggroups: Create reggroup_gdbarch_new for dynamic reggroups Stafford Horne
2017-12-21 3:15 ` Simon Marchi
2017-12-19 14:23 ` [PATCH v3 1/4] reggroups: Add test and docs for `info reg $reggroup` feature Stafford Horne
2017-12-19 16:23 ` Eli Zaretskii
2017-12-20 10:40 ` Stafford Horne
2017-12-21 2:40 ` Simon Marchi [this message]
2017-12-21 3:40 ` Eli Zaretskii
2017-12-21 2:59 ` Simon Marchi
2017-12-24 14:47 ` Stafford Horne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=596161e11663add8b95ca70dd1f8f12b@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=openrisc@lists.librecores.org \
--cc=shorne@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox