Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Stafford Horne <shorne@gmail.com>
To: GDB patches <gdb-patches@sourceware.org>
Cc: Openrisc <openrisc@lists.librecores.org>,
	Stafford Horne <shorne@gmail.com>
Subject: [PATCH v3 3/4] reggroups: Create reggroup_gdbarch_new for dynamic reggroups
Date: Tue, 19 Dec 2017 14:23:00 -0000	[thread overview]
Message-ID: <20171219142257.13402-4-shorne@gmail.com> (raw)
In-Reply-To: <20171219142257.13402-1-shorne@gmail.com>

Traditionally reggroups have been created via reggroup_new() during
initialization code and never freed.  Now, if we want to initialize
reggroups dynamically (i.e. in target description) we should be able to
free them.  Create this function reggroup_gdbarch_new() which will
allocate the reggroup memory onto the passed gdbarch obstack.

gdb/ChangeLog:

2017-06-10  Stafford Horne  <shorne@gmail.com>

	* reggroups.c (reggroup_gdbarch_new): New function.
	* reggroups.h (reggroup_gdbarch_new): New function.
---
 gdb/reggroups.c | 12 ++++++++++++
 gdb/reggroups.h |  4 ++++
 2 files changed, 16 insertions(+)

diff --git a/gdb/reggroups.c b/gdb/reggroups.c
index 5d5e33f2a3..acad91a0ab 100644
--- a/gdb/reggroups.c
+++ b/gdb/reggroups.c
@@ -46,6 +46,18 @@ reggroup_new (const char *name, enum reggroup_type type)
   return group;
 }
 
+struct reggroup *
+reggroup_gdbarch_new (struct gdbarch *gdbarch, const char *name,
+		      enum reggroup_type type)
+{
+  struct reggroup *group = GDBARCH_OBSTACK_ZALLOC (gdbarch,
+						   struct reggroup);
+
+  group->name = gdbarch_obstack_strdup (gdbarch, name);
+  group->type = type;
+  return group;
+}
+
 /* Register group attributes.  */
 
 const char *
diff --git a/gdb/reggroups.h b/gdb/reggroups.h
index 18fc1bf294..c1653cd39d 100644
--- a/gdb/reggroups.h
+++ b/gdb/reggroups.h
@@ -41,6 +41,10 @@ extern struct reggroup *const restore_reggroup;
 /* Create a new local register group.  */
 extern struct reggroup *reggroup_new (const char *name,
 				      enum reggroup_type type);
+/* Create a new register group allocated onto the gdbarch obstack.  */
+extern struct reggroup *reggroup_gdbarch_new (struct gdbarch *gdbarch,
+					      const char *name,
+					      enum reggroup_type type);
 
 /* Add a register group (with attribute values) to the pre-defined list.  */
 extern void reggroup_add (struct gdbarch *gdbarch, struct reggroup *group);
-- 
2.13.6


  parent reply	other threads:[~2017-12-19 14:23 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-19 14:23 [PATCH v3 0/4] Support for arbitrary reggroups Stafford Horne
2017-12-19 14:23 ` [PATCH v3 4/4] tdesc: handle arbitrary strings in tdesc_register_in_reggroup_p Stafford Horne
2017-12-19 16:27   ` Eli Zaretskii
2017-12-19 22:13     ` Stafford Horne
2017-12-20 13:35       ` Stafford Horne
2017-12-20 16:37       ` Eli Zaretskii
2017-12-21  3:29   ` Simon Marchi
2017-12-21 12:55     ` Stafford Horne
2017-12-19 14:23 ` Stafford Horne [this message]
2017-12-21  3:15   ` [PATCH v3 3/4] reggroups: Create reggroup_gdbarch_new for dynamic reggroups Simon Marchi
2017-12-19 14:23 ` [PATCH v3 2/4] reggroups: Convert reggroups from post_init to pre_init Stafford Horne
2017-12-21  3:03   ` Simon Marchi
2017-12-19 14:23 ` [PATCH v3 1/4] reggroups: Add test and docs for `info reg $reggroup` feature Stafford Horne
2017-12-19 16:23   ` Eli Zaretskii
2017-12-20 10:40     ` Stafford Horne
2017-12-21  2:40     ` Simon Marchi
2017-12-21  3:40       ` Eli Zaretskii
2017-12-21  2:59   ` Simon Marchi
2017-12-24 14:47     ` Stafford Horne

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171219142257.13402-4-shorne@gmail.com \
    --to=shorne@gmail.com \
    --cc=gdb-patches@sourceware.org \
    --cc=openrisc@lists.librecores.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox