From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10199 invoked by alias); 20 Dec 2017 16:37:09 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 10183 invoked by uid 89); 20 Dec 2017 16:37:08 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy= X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (208.118.235.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 20 Dec 2017 16:37:06 +0000 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eRhMX-0000V8-7Q for gdb-patches@sourceware.org; Wed, 20 Dec 2017 11:37:04 -0500 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:35404) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eRgxc-0005g8-Ua; Wed, 20 Dec 2017 11:11:12 -0500 Received: from [176.228.60.248] (port=3308 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1eRggc-000423-UG; Wed, 20 Dec 2017 10:53:39 -0500 Date: Wed, 20 Dec 2017 16:37:00 -0000 Message-Id: <83r2rpo0of.fsf@gnu.org> From: Eli Zaretskii To: Stafford Horne CC: gdb-patches@sourceware.org, openrisc@lists.librecores.org In-reply-to: <20171219221300.GB32243@lianli.shorne-pla.net> (message from Stafford Horne on Wed, 20 Dec 2017 07:13:00 +0900) Subject: Re: [PATCH v3 4/4] tdesc: handle arbitrary strings in tdesc_register_in_reggroup_p Reply-to: Eli Zaretskii References: <20171219142257.13402-1-shorne@gmail.com> <20171219142257.13402-5-shorne@gmail.com> <836092ptsa.fsf@gnu.org> <20171219221300.GB32243@lianli.shorne-pla.net> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-IsSubscribed: yes X-SW-Source: 2017-12/txt/msg00454.txt.bz2 > Date: Wed, 20 Dec 2017 07:13:00 +0900 > From: Stafford Horne > Cc: gdb-patches@sourceware.org, openrisc@lists.librecores.org > > > > @item group > > > -The register group to which this register belongs. It must > > > -be either @code{general}, @code{float}, or @code{vector}. If no > > > -@var{group} is specified, @value{GDBN} will not display the register > > > -in @code{info registers}. > > > +The register group to which this register belongs. It can be one of the > > > +standard register groups @code{general}, @code{float}, @code{vector} or an > > > +arbitrary string. The string should be limited to alphanumeric characters > > > +and internal hyphens. If no @var{group} is specified, @value{GDBN} will > > > > What do you mean by "internal hyphens"? > > This means, hyphens withing the register group name, not starting or ending with > hyphens. (i.e. special-spr, but not rg1- or -rg2) Then I think this text needs to be rephrased, so that it first says what are the characters allowed in a reggroup name, and then says that ranges of groups, with 2 group names separated by hyphens, are also accepted. Thanks.