From: Eli Zaretskii <eliz@gnu.org>
To: andrew.burgess@embecosm.com, tromey@sourceware.org,
gdb-patches@sourceware.org
Subject: Re: [review v3] gdb/mi: Add new commands -symbol-info-{functions,variables,types}
Date: Fri, 08 Nov 2019 10:10:00 -0000 [thread overview]
Message-ID: <83pni2d6gf.fsf@gnu.org> (raw)
In-Reply-To: <20191108005037.8B63F2816A@gnutoolchain-gerrit.osci.io>
> Date: Thu, 7 Nov 2019 19:50:32 -0500
> From: "Andrew Burgess (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>
>
> gdb/mi: Add new commands -symbol-info-{functions,variables,types}
>
> Add new MI commands -symbol-info-functions, -symbol-info-variables,
> and -symbol-info-types which correspond to the CLI commands 'info
> functions', 'info variables', and 'info types' respectively.
>
> gdb/ChangeLog:
>
> * mi/mi-cmds.c (mi_cmds): Add '-symbol-info-functions',
> '-symbol-info-variables', and '-symbol-info-types'.
> * mi/mi-cmds.h (mi_cmd_symbol_info_functions): Declare.
> (mi_cmd_symbol_info_variables): Declare.
> (mi_cmd_symbol_info_types): Declare.
> * mi/mi-symbol-cmds.c: Add 'source.h' and 'mi-getopt.h' includes.
> (mi_info_one_symbol_details): New function.
> (class mi_symbol_info_emitter): New class.
> (mi_symbol_info): New function.
> (mi_info_functions_or_variables): New function.
> (mi_cmd_symbol_info_functions): New function.
> (mi_cmd_symbol_info_types): New function.
> (mi_cmd_symbol_info_variables): New function.
> * NEWS: Mention new commands.
>
> gdb/testsuite/ChangeLog:
>
> * gdb.mi/mi-sym-info-1.c: New file.
> * gdb.mi/mi-sym-info-2.c: New file.
> * gdb.mi/mi-sym-info.exp: New file.
>
> gdb/doc/ChangeLog:
>
> * doc/gdb.texinfo (GDB/MI Symbol Query): Document new MI command
> -symbol-info-functions, -symbol-info-types, and
> -symbol-info-variables.
OK for the documentation parts.
Thanks.
next prev parent reply other threads:[~2019-11-08 10:10 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <gerrit.1571909344000.Ic2fc6a6750bbce91cdde2344791014e5ef45642d@gnutoolchain-gerrit.osci.io>
2019-10-30 15:02 ` [review] " Tom Tromey (Code Review)
2019-11-01 1:28 ` [review v2] " Andrew Burgess (Code Review)
2019-11-01 1:36 ` Andrew Burgess (Code Review)
2019-11-08 0:50 ` [review v3] " Andrew Burgess (Code Review)
2019-11-08 10:10 ` Eli Zaretskii [this message]
2019-11-21 5:39 ` Simon Marchi (Code Review)
2019-11-22 16:42 ` [review v4] " Andrew Burgess (Code Review)
2019-11-22 19:29 ` Eli Zaretskii
2019-11-22 17:32 ` [review v5] " Andrew Burgess (Code Review)
2019-11-26 23:26 ` [review v6] " Andrew Burgess (Code Review)
2019-11-26 23:46 ` [review v7] " Andrew Burgess (Code Review)
2019-11-27 4:08 ` Simon Marchi (Code Review)
2019-11-27 4:11 ` Simon Marchi (Code Review)
2019-11-27 13:03 ` [pushed] " Sourceware to Gerrit sync (Code Review)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83pni2d6gf.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox