From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 48655 invoked by alias); 8 Nov 2019 10:10:37 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 48642 invoked by uid 89); 8 Nov 2019 10:10:37 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.6 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (209.51.188.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 08 Nov 2019 10:10:36 +0000 Received: from fencepost.gnu.org ([2001:470:142:3::e]:33678) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iT1Du-0000Za-SA; Fri, 08 Nov 2019 05:10:34 -0500 Received: from [176.228.60.248] (port=2146 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iT1Du-0007BF-0L; Fri, 08 Nov 2019 05:10:34 -0500 Date: Fri, 08 Nov 2019 10:10:00 -0000 Message-Id: <83pni2d6gf.fsf@gnu.org> From: Eli Zaretskii To: andrew.burgess@embecosm.com, tromey@sourceware.org, gdb-patches@sourceware.org In-reply-to: <20191108005037.8B63F2816A@gnutoolchain-gerrit.osci.io> Subject: Re: [review v3] gdb/mi: Add new commands -symbol-info-{functions,variables,types} References: <20191108005037.8B63F2816A@gnutoolchain-gerrit.osci.io> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-IsSubscribed: yes X-SW-Source: 2019-11/txt/msg00224.txt.bz2 > Date: Thu, 7 Nov 2019 19:50:32 -0500 > From: "Andrew Burgess (Code Review)" > > gdb/mi: Add new commands -symbol-info-{functions,variables,types} > > Add new MI commands -symbol-info-functions, -symbol-info-variables, > and -symbol-info-types which correspond to the CLI commands 'info > functions', 'info variables', and 'info types' respectively. > > gdb/ChangeLog: > > * mi/mi-cmds.c (mi_cmds): Add '-symbol-info-functions', > '-symbol-info-variables', and '-symbol-info-types'. > * mi/mi-cmds.h (mi_cmd_symbol_info_functions): Declare. > (mi_cmd_symbol_info_variables): Declare. > (mi_cmd_symbol_info_types): Declare. > * mi/mi-symbol-cmds.c: Add 'source.h' and 'mi-getopt.h' includes. > (mi_info_one_symbol_details): New function. > (class mi_symbol_info_emitter): New class. > (mi_symbol_info): New function. > (mi_info_functions_or_variables): New function. > (mi_cmd_symbol_info_functions): New function. > (mi_cmd_symbol_info_types): New function. > (mi_cmd_symbol_info_variables): New function. > * NEWS: Mention new commands. > > gdb/testsuite/ChangeLog: > > * gdb.mi/mi-sym-info-1.c: New file. > * gdb.mi/mi-sym-info-2.c: New file. > * gdb.mi/mi-sym-info.exp: New file. > > gdb/doc/ChangeLog: > > * doc/gdb.texinfo (GDB/MI Symbol Query): Document new MI command > -symbol-info-functions, -symbol-info-types, and > -symbol-info-variables. OK for the documentation parts. Thanks.