[review v7] gdb/mi: Add new commands -symbol-info-{functions,variables,types}

["Simon Marchi (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>]

Simon Marchi has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/266
......................................................................


Patch Set 7:

(2 comments)

Missing space here too.

| --- gdb/mi/mi-symbol-cmds.c
| +++ gdb/mi/mi-symbol-cmds.c
| @@ -62,0 +105,19 @@ output_nondebug_symbol (ui_out *uiout,
| +}
| +
| +/* This is the guts of the commands '-symbol-info-functions',
| +   '-symbol-info-variables', and '-symbol-info-types'.  It searches for
| +   symbols matching KING, REGEXP, T_REGEXP, and EXCLUDE_MINSYMS, and then
| +   prints the matching [m]symbols in an MI structured format.  */
| +
| +static void
| +mi_symbol_info (enum search_domain kind, const char *regexp,
| +		const char *t_regexp, bool exclude_minsyms)

PS7, Line 114:

As mentioned previously, I think it would be clearer to do

 regexp -> name_regexp
 t_regexp -> type_regexp

| +{
| +  global_symbol_searcher sym_search (kind, regexp);
| +  sym_search.set_symbol_type_regexp (t_regexp);
| +  sym_search.set_exclude_minsyms (exclude_minsyms);
| +  std::vector<symbol_search> symbols = sym_search.search ();
| +  ui_out *uiout = current_uiout;
| +  int i = 0;
| +
| +  ui_out_emit_tuple outer_symbols_emitter (uiout, "symbols");

 ...

| @@ -62,0 +141,19 @@ mi_symbol_info (enum search_domain kind, const char *regexp,
| +
| +	  /* As long as we have debug symbols from this symtab...  */
| +	  for (; (i < symbols.size ()
| +		  && symbols[i].msymbol.minsym == nullptr
| +		  && symbol_symtab (symbols[i].symbol) == symtab);
| +	       ++i)
| +	    {
| +	      symbol_search &s = symbols[i];
| +
| +	      output_debug_symbol(uiout, kind, s.symbol, s.block);

PS7, Line 150:

Oops, missing space.

| +	    }
| +	}
| +    }
| +
| +  /* Non-debug symbols are placed after.  */
| +  if (i < symbols.size ())
| +    {
| +      ui_out_emit_list nondebug_symbols_list_emitter (uiout, "nondebug");
| +

-- 
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: Ic2fc6a6750bbce91cdde2344791014e5ef45642d
Gerrit-Change-Number: 266
Gerrit-PatchSet: 7
Gerrit-Owner: Andrew Burgess <andrew.burgess@embecosm.com>
Gerrit-Reviewer: Andrew Burgess <andrew.burgess@embecosm.com>
Gerrit-Reviewer: Tom Tromey <tromey@sourceware.org>
Gerrit-CC: Joel Brobecker <brobecker@adacore.com>
Gerrit-CC: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-Comment-Date: Wed, 27 Nov 2019 04:08:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment