[review] gdb/mi: Add new commands -symbol-info-{functions,variables,types}

["Tom Tromey (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>]

Tom Tromey has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/266
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

Thank you, this looks good to me.

https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/266/1/gdb/mi/mi-symbol-cmds.c 
File gdb/mi/mi-symbol-cmds.c:

https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/266/1/gdb/mi/mi-symbol-cmds.c@117 
PS1, Line 117: 
102 | mi_symbol_info (enum search_domain kind, const char *regexp,
    | ...
111 |   /* The outer container for all the matched symbols.  */
112 |   ui_out_emit_tuple all_matching_symbols (uiout, "symbols");
113 | 
114 |   /* The order of these optional emitters is critical as they will be
115 |      deleted in reverse order, which is important as these are popped from
116 |      the uiout stack as they are destroyed.  */
117 |   gdb::optional<ui_out_emit_list> debug_func_emitter_outer;
118 |   gdb::optional<ui_out_emit_tuple> debug_func_emitter_symtab;
119 |   gdb::optional<ui_out_emit_list> debug_func_emitter_symbols;
120 |   gdb::optional<ui_out_emit_list> nondebug_func_emitter;

I wonder if there's a better way.  It's ok if not, this is just
giving me bad memories of the way the disassembly code manages
this stuff.



-- 
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: Ic2fc6a6750bbce91cdde2344791014e5ef45642d
Gerrit-Change-Number: 266
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Burgess <andrew.burgess@embecosm.com>
Gerrit-Reviewer: Tom Tromey <tromey@sourceware.org>
Gerrit-Comment-Date: Wed, 30 Oct 2019 15:02:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment