From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 50491 invoked by alias); 30 Oct 2019 15:02:34 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 50482 invoked by uid 89); 30 Oct 2019 15:02:34 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.3.1 spammy= X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 30 Oct 2019 15:02:33 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id 82486203A5; Wed, 30 Oct 2019 11:02:31 -0400 (EDT) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [IPv6:2620:52:3:1:5054:ff:fe06:16ca]) by mx1.osci.io (Postfix) with ESMTP id 12BBC20322; Wed, 30 Oct 2019 11:02:30 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id D9F8F20AF6; Wed, 30 Oct 2019 11:02:29 -0400 (EDT) X-Gerrit-PatchSet: 1 Date: Wed, 30 Oct 2019 15:02:00 -0000 From: "Tom Tromey (Code Review)" To: Andrew Burgess , gdb-patches@sourceware.org Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review] gdb/mi: Add new commands -symbol-info-{functions,variables,types} X-Gerrit-Change-Id: Ic2fc6a6750bbce91cdde2344791014e5ef45642d X-Gerrit-Change-Number: 266 X-Gerrit-ChangeURL: X-Gerrit-Commit: 313cc059c7de7d4065c0b38626112ce580fec5cd In-Reply-To: References: X-Gerrit-Comment-Date: Wed, 30 Oct 2019 11:02:29 -0400 Reply-To: gnutoolchain-gerrit@osci.io MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3-74-g460fb0f7e9 Content-Type: text/plain; charset=UTF-8 Message-Id: <20191030150229.D9F8F20AF6@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-10/txt/msg01095.txt.bz2 Tom Tromey has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/266 ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Thank you, this looks good to me. https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/266/1/gdb/mi/mi-symbol-cmds.c File gdb/mi/mi-symbol-cmds.c: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/266/1/gdb/mi/mi-symbol-cmds.c@117 PS1, Line 117: 102 | mi_symbol_info (enum search_domain kind, const char *regexp, | ... 111 | /* The outer container for all the matched symbols. */ 112 | ui_out_emit_tuple all_matching_symbols (uiout, "symbols"); 113 | 114 | /* The order of these optional emitters is critical as they will be 115 | deleted in reverse order, which is important as these are popped from 116 | the uiout stack as they are destroyed. */ 117 | gdb::optional debug_func_emitter_outer; 118 | gdb::optional debug_func_emitter_symtab; 119 | gdb::optional debug_func_emitter_symbols; 120 | gdb::optional nondebug_func_emitter; I wonder if there's a better way. It's ok if not, this is just giving me bad memories of the way the disassembly code manages this stuff. -- Gerrit-Project: binutils-gdb Gerrit-Branch: master Gerrit-Change-Id: Ic2fc6a6750bbce91cdde2344791014e5ef45642d Gerrit-Change-Number: 266 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Burgess Gerrit-Reviewer: Tom Tromey Gerrit-Comment-Date: Wed, 30 Oct 2019 15:02:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment