From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 43152 invoked by alias); 27 Nov 2019 04:08:28 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 43133 invoked by uid 89); 27 Nov 2019 04:08:28 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-11.9 required=5.0 tests=BAYES_00,GIT_PATCH_2,GIT_PATCH_3 autolearn=ham version=3.3.1 spammy= X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 27 Nov 2019 04:08:17 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id 49B9720391; Tue, 26 Nov 2019 23:08:16 -0500 (EST) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [IPv6:2620:52:3:1:5054:ff:fe06:16ca]) by mx1.osci.io (Postfix) with ESMTP id C60A520187; Tue, 26 Nov 2019 23:08:06 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id 28E5520AF6; Tue, 26 Nov 2019 23:08:06 -0500 (EST) X-Gerrit-PatchSet: 7 Date: Wed, 27 Nov 2019 04:08:00 -0000 From: "Simon Marchi (Code Review)" To: Andrew Burgess , gdb-patches@sourceware.org Cc: Joel Brobecker , Tom Tromey Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review v7] gdb/mi: Add new commands -symbol-info-{functions,variables,types} X-Gerrit-Change-Id: Ic2fc6a6750bbce91cdde2344791014e5ef45642d X-Gerrit-Change-Number: 266 X-Gerrit-ChangeURL: X-Gerrit-Commit: 93b4867c1285f4b025e2f12029ec19a7ce51c286 In-Reply-To: References: X-Gerrit-Comment-Date: Tue, 26 Nov 2019 23:08:05 -0500 Reply-To: gnutoolchain-gerrit@osci.io MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3-79-g83ff7f88f1 Content-Type: text/plain; charset=UTF-8 Message-Id: <20191127040806.28E5520AF6@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-11/txt/msg01017.txt.bz2 Simon Marchi has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/266 ...................................................................... Patch Set 7: (2 comments) Missing space here too. | --- gdb/mi/mi-symbol-cmds.c | +++ gdb/mi/mi-symbol-cmds.c | @@ -62,0 +105,19 @@ output_nondebug_symbol (ui_out *uiout, | +} | + | +/* This is the guts of the commands '-symbol-info-functions', | + '-symbol-info-variables', and '-symbol-info-types'. It searches for | + symbols matching KING, REGEXP, T_REGEXP, and EXCLUDE_MINSYMS, and then | + prints the matching [m]symbols in an MI structured format. */ | + | +static void | +mi_symbol_info (enum search_domain kind, const char *regexp, | + const char *t_regexp, bool exclude_minsyms) PS7, Line 114: As mentioned previously, I think it would be clearer to do regexp -> name_regexp t_regexp -> type_regexp | +{ | + global_symbol_searcher sym_search (kind, regexp); | + sym_search.set_symbol_type_regexp (t_regexp); | + sym_search.set_exclude_minsyms (exclude_minsyms); | + std::vector symbols = sym_search.search (); | + ui_out *uiout = current_uiout; | + int i = 0; | + | + ui_out_emit_tuple outer_symbols_emitter (uiout, "symbols"); ... | @@ -62,0 +141,19 @@ mi_symbol_info (enum search_domain kind, const char *regexp, | + | + /* As long as we have debug symbols from this symtab... */ | + for (; (i < symbols.size () | + && symbols[i].msymbol.minsym == nullptr | + && symbol_symtab (symbols[i].symbol) == symtab); | + ++i) | + { | + symbol_search &s = symbols[i]; | + | + output_debug_symbol(uiout, kind, s.symbol, s.block); PS7, Line 150: Oops, missing space. | + } | + } | + } | + | + /* Non-debug symbols are placed after. */ | + if (i < symbols.size ()) | + { | + ui_out_emit_list nondebug_symbols_list_emitter (uiout, "nondebug"); | + -- Gerrit-Project: binutils-gdb Gerrit-Branch: master Gerrit-Change-Id: Ic2fc6a6750bbce91cdde2344791014e5ef45642d Gerrit-Change-Number: 266 Gerrit-PatchSet: 7 Gerrit-Owner: Andrew Burgess Gerrit-Reviewer: Andrew Burgess Gerrit-Reviewer: Tom Tromey Gerrit-CC: Joel Brobecker Gerrit-CC: Simon Marchi Gerrit-Comment-Date: Wed, 27 Nov 2019 04:08:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment