From: Eli Zaretskii <eliz@gnu.org>
To: Andrew Burgess <andrew.burgess@embecosm.com>
Cc: gdb-patches@sourceware.org, Richard.Bunt@arm.com
Subject: Re: [PATCH 1/7] gdb: Add new -n flag to some info commands
Date: Sat, 27 Jul 2019 16:41:00 -0000 [thread overview]
Message-ID: <83o91fl9b9.fsf@gnu.org> (raw)
In-Reply-To: <c08d0e63a42dce6821f59162098ff0068c12a41a.1564243858.git.andrew.burgess@embecosm.com> (message from Andrew Burgess on Sat, 27 Jul 2019 17:22:29 +0100)
> From: Andrew Burgess <andrew.burgess@embecosm.com>
> Cc: Richard Bunt <Richard.Bunt@arm.com>, Andrew Burgess <andrew.burgess@embecosm.com>
> Date: Sat, 27 Jul 2019 17:22:29 +0100
>
> index cc1d58520d4..40b56727227 100644
> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -215,6 +215,10 @@ maint show test-options-completion-result
> printing of some header information in a similar fashion to "info
> variables" and "info functions".
>
> + ** The "info variables", "info functions", and "whereis" commands
> + now take a '-n' flag that excludes non-debug symbols from the
> + results.
I'm afraid "non-debug symbols" will not be self-explanatory enough.
Can we say something more concrete here, or at least give a couple of
examples?
> +By default, the command will include non-debug symbols in the output\n\
> +these can be excluded using the -n flag." : ""));
I believe we need a semi-colon after "output".
> +Non-debug symbols are also included in the results if the symbols are
> +of a type that indicates they might be for executable code. The
> +@samp{-n} flag excludes non-debugging symbols from the results.
Please add here text that explains what are "non-debug symbols". I
also had difficulty understanding what does "a type that indicates
they might be for executable code" means, so maybe clarify that as
well.
> @@ -18587,11 +18591,15 @@
> language of the variable, other values mean to use
> the manually specified language (see @ref{Manually, ,Set Language Manually}).
>
> +Non-debug symbols are also included in the results if the symbols are
> +of a type that indicates they might be for data objects. The
> +@samp{-n} flag excludes non-debugging symbols from the results.
Same here.
Thanks.
next prev parent reply other threads:[~2019-07-27 16:41 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-27 16:22 [PATCH 0/7] Fortran info types, info modules, info module Andrew Burgess
2019-07-27 16:22 ` [PATCH 3/7] gdb/fortran: Include module variables in 'info variables' output Andrew Burgess
2019-07-27 16:22 ` [PATCH 2/7] gdb: Add an is_declaration field to each symbol Andrew Burgess
2019-07-29 20:21 ` Tom Tromey
2019-07-30 21:00 ` Andrew Burgess
2019-07-27 16:23 ` [PATCH 1/7] gdb: Add new -n flag to some info commands Andrew Burgess
2019-07-27 16:41 ` Eli Zaretskii [this message]
2019-07-30 21:02 ` Andrew Burgess
2019-07-31 14:51 ` Eli Zaretskii
2019-08-26 15:52 ` Andrew Burgess
2019-08-26 16:19 ` Eli Zaretskii
2019-08-27 15:27 ` Andrew Burgess
2019-08-28 15:13 ` [committed][gdb/testsuite] Fix info-var.exp for debug info from other files Tom de Vries
2019-07-29 20:23 ` [PATCH 1/7] gdb: Add new -n flag to some info commands Tom Tromey
2019-07-27 16:23 ` [PATCH 6/7] gdb/fortran: Add new 'info modules' command Andrew Burgess
2019-07-27 16:45 ` Eli Zaretskii
2019-07-29 20:30 ` Tom Tromey
2019-07-27 16:23 ` [PATCH 4/7] gdb/fortran: Implement la_print_typedef for Fortran Andrew Burgess
2019-08-28 12:37 ` Andrew Burgess
2019-07-27 16:23 ` [PATCH 7/7] gdb: Add new commands to list module variables and functions Andrew Burgess
2019-07-27 17:06 ` Eli Zaretskii
2019-07-27 16:23 ` [PATCH 5/7] gdb/fortran: Don't include module symbols when searching for types Andrew Burgess
2019-08-28 12:37 ` Andrew Burgess
2019-08-29 9:09 ` Tom de Vries
2019-08-29 11:45 ` Tom de Vries
2019-08-29 12:47 ` [committed][gdb/testsuite] Fix gdb.fortran/info-types.exp regexp Tom de Vries
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83o91fl9b9.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=Richard.Bunt@arm.com \
--cc=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox