From: Andrew Burgess <andrew.burgess@embecosm.com>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org, Richard Bunt <Richard.Bunt@arm.com>
Subject: Re: [PATCH 2/7] gdb: Add an is_declaration field to each symbol
Date: Tue, 30 Jul 2019 21:00:00 -0000 [thread overview]
Message-ID: <20190730210019.GM23204@embecosm.com> (raw)
In-Reply-To: <87blxcpp5y.fsf@tromey.com>
* Tom Tromey <tom@tromey.com> [2019-07-29 14:21:45 -0600]:
> >>>>> "Andrew" == Andrew Burgess <andrew.burgess@embecosm.com> writes:
>
> Andrew> Track if a symbol is a declaration or not. At one point we could
> Andrew> possibly figure this out based on the LOC_UNRESOLVED address class of
> Andrew> the symbol, but, for Fortran we mark some symbols as LOC_UNRESOLVED
> Andrew> even when the DWARF supplies an address, this is because the address
> Andrew> supplied by the DWARF is actually wrong. For details look in
> Andrew> dwarf2read.c and look for references to gFortran bug #40040. I have
> Andrew> confirmed that current versions of gFortran still have the issue
> Andrew> mentioned in that bug report.
>
> That bug looks like another instance of the copy relocation problem.
> So, I wonder if these workarounds could be removed if/when this series
> lands:
>
> https://sourceware.org/ml/gdb-patches/2019-06/msg00612.html
>
> (I still haven't looked at Pedro's review in detail, but I will get to
> it sooner or later.)
I checked your copy relocation series does indeed make parts #2 and #3
of my series redundant.
I'll address the other feedback with this series and rebase once your
series lands.
Thanks,
Andrew
next prev parent reply other threads:[~2019-07-30 21:00 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-27 16:22 [PATCH 0/7] Fortran info types, info modules, info module Andrew Burgess
2019-07-27 16:22 ` [PATCH 2/7] gdb: Add an is_declaration field to each symbol Andrew Burgess
2019-07-29 20:21 ` Tom Tromey
2019-07-30 21:00 ` Andrew Burgess [this message]
2019-07-27 16:22 ` [PATCH 3/7] gdb/fortran: Include module variables in 'info variables' output Andrew Burgess
2019-07-27 16:23 ` [PATCH 5/7] gdb/fortran: Don't include module symbols when searching for types Andrew Burgess
2019-08-28 12:37 ` Andrew Burgess
2019-08-29 9:09 ` Tom de Vries
2019-08-29 11:45 ` Tom de Vries
2019-08-29 12:47 ` [committed][gdb/testsuite] Fix gdb.fortran/info-types.exp regexp Tom de Vries
2019-07-27 16:23 ` [PATCH 1/7] gdb: Add new -n flag to some info commands Andrew Burgess
2019-07-27 16:41 ` Eli Zaretskii
2019-07-30 21:02 ` Andrew Burgess
2019-07-31 14:51 ` Eli Zaretskii
2019-08-26 15:52 ` Andrew Burgess
2019-08-26 16:19 ` Eli Zaretskii
2019-08-27 15:27 ` Andrew Burgess
2019-08-28 15:13 ` [committed][gdb/testsuite] Fix info-var.exp for debug info from other files Tom de Vries
2019-07-29 20:23 ` [PATCH 1/7] gdb: Add new -n flag to some info commands Tom Tromey
2019-07-27 16:23 ` [PATCH 6/7] gdb/fortran: Add new 'info modules' command Andrew Burgess
2019-07-27 16:45 ` Eli Zaretskii
2019-07-29 20:30 ` Tom Tromey
2019-07-27 16:23 ` [PATCH 4/7] gdb/fortran: Implement la_print_typedef for Fortran Andrew Burgess
2019-08-28 12:37 ` Andrew Burgess
2019-07-27 16:23 ` [PATCH 7/7] gdb: Add new commands to list module variables and functions Andrew Burgess
2019-07-27 17:06 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190730210019.GM23204@embecosm.com \
--to=andrew.burgess@embecosm.com \
--cc=Richard.Bunt@arm.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox