From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5337 invoked by alias); 30 Jul 2019 21:00:27 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 1971 invoked by uid 89); 30 Jul 2019 21:00:25 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-12.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=Track, is_declaration X-HELO: mail-wm1-f66.google.com Received: from mail-wm1-f66.google.com (HELO mail-wm1-f66.google.com) (209.85.128.66) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 30 Jul 2019 21:00:24 +0000 Received: by mail-wm1-f66.google.com with SMTP id u25so47488612wmc.4 for ; Tue, 30 Jul 2019 14:00:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=s2BTO2/VL+Jn7NCRYm/KPOC4OxwAx+WqHd0JQD+z7zU=; b=TQVyJwKGx+WhY9DRrMu59+mkhSUqESKGnU3/mMvKIH4cCv7AyHg68wB5E2iL/YqtTZ iOzMEMaV9y1iuJkYjA96IsR1w4FOcQgJnv+PC/wS3Dv93vd7qKTLwG5mhZ8kxBLydagJ gOeGUZIqy3EexInPk0YSkJip4jDTh7+7J5fSft1MnzD1eguF2bl2mcv+bp/92iM0pBo6 TKrr+G52QzMe8J/InEos3RPxOGWK2R+gqMXLYJ+KskOIajvs69rDVCMfSQiJgxHcexRY m7QgonwK0aP7u8l9aB3Cga4SFDu/8Nnlow07wi9vUBFB8hjI7930E9fZ9xOtL+mH6c7a oRpg== Return-Path: Received: from localhost (host86-128-12-79.range86-128.btcentralplus.com. [86.128.12.79]) by smtp.gmail.com with ESMTPSA id y16sm66700152wrw.33.2019.07.30.14.00.20 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 30 Jul 2019 14:00:21 -0700 (PDT) Date: Tue, 30 Jul 2019 21:00:00 -0000 From: Andrew Burgess To: Tom Tromey Cc: gdb-patches@sourceware.org, Richard Bunt Subject: Re: [PATCH 2/7] gdb: Add an is_declaration field to each symbol Message-ID: <20190730210019.GM23204@embecosm.com> References: <02a60599e2dff9efead7adbb070733c0f4c65f04.1564243858.git.andrew.burgess@embecosm.com> <87blxcpp5y.fsf@tromey.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87blxcpp5y.fsf@tromey.com> X-Fortune: I'm rated PG-34!! X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] User-Agent: Mutt/1.9.2 (2017-12-15) X-IsSubscribed: yes X-SW-Source: 2019-07/txt/msg00666.txt.bz2 * Tom Tromey [2019-07-29 14:21:45 -0600]: > >>>>> "Andrew" == Andrew Burgess writes: > > Andrew> Track if a symbol is a declaration or not. At one point we could > Andrew> possibly figure this out based on the LOC_UNRESOLVED address class of > Andrew> the symbol, but, for Fortran we mark some symbols as LOC_UNRESOLVED > Andrew> even when the DWARF supplies an address, this is because the address > Andrew> supplied by the DWARF is actually wrong. For details look in > Andrew> dwarf2read.c and look for references to gFortran bug #40040. I have > Andrew> confirmed that current versions of gFortran still have the issue > Andrew> mentioned in that bug report. > > That bug looks like another instance of the copy relocation problem. > So, I wonder if these workarounds could be removed if/when this series > lands: > > https://sourceware.org/ml/gdb-patches/2019-06/msg00612.html > > (I still haven't looked at Pedro's review in detail, but I will get to > it sooner or later.) I checked your copy relocation series does indeed make parts #2 and #3 of my series redundant. I'll address the other feedback with this series and rebase once your series lands. Thanks, Andrew