From: Tom de Vries <tdevries@suse.de>
To: Andrew Burgess <andrew.burgess@embecosm.com>, gdb-patches@sourceware.org
Cc: Richard Bunt <Richard.Bunt@arm.com>
Subject: Re: [PATCH 5/7] gdb/fortran: Don't include module symbols when searching for types
Date: Thu, 29 Aug 2019 11:45:00 -0000 [thread overview]
Message-ID: <4aae6453-0369-0d35-8638-196732a9ad4f@suse.de> (raw)
In-Reply-To: <557e551b-62a8-b501-1f6a-c9569dfb4031@suse.de>
On 29-08-19 11:09, Tom de Vries wrote:
> On 28-08-19 14:37, Andrew Burgess wrote:
>> * Andrew Burgess <andrew.burgess@embecosm.com> [2019-07-27 17:22:33 +0100]:
>>
>>> Currently the 'info types' command will return symbols that correspond
>>> to Fortran modules. This because the symbols are created with domain
>>> MODULE_DOMAIN, but address_class LOC_TYPEDEF, which is the same
>>> address_class as type symbols.
>>>
>>> This commit explicitly prevents MODULE_DOMAIN symbols from appearing
>>> when we search for symbols in the TYPES_DOMAIN, this prevents the
>>> module symbols from appearing in the output of 'info types'.
>>>
>>> gdb/ChangeLog:
>>>
>>> * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
>>> when searching for types.
>>>
>>> gdb/testsuite/ChangeLog:
>>>
>>> * gdb.fortran/info-types.exp: Add module.
>>> * gdb.fortran/info-types.f90: Update expected results.
>>
>> I've now pushed this patch as it only depended on the previous patch
>> in this series.
>
> Also, this test-case times out with check-read1, due to the many
> "Non-debugging symbols" that are parsed by a single .*.
Sorry, wrong thread, this is about gdb.base/info-var.exp:
...
FAIL: gdb.base/info-var.exp: info variables (timeout)
FAIL: gdb.base/info-var.exp: info variables -n (timeout)
FAIL: gdb.base/info-var.exp: info variables -n global (timeout)
...
Thanks,
- Tom
next prev parent reply other threads:[~2019-08-29 11:45 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-27 16:22 [PATCH 0/7] Fortran info types, info modules, info module Andrew Burgess
2019-07-27 16:22 ` [PATCH 3/7] gdb/fortran: Include module variables in 'info variables' output Andrew Burgess
2019-07-27 16:22 ` [PATCH 2/7] gdb: Add an is_declaration field to each symbol Andrew Burgess
2019-07-29 20:21 ` Tom Tromey
2019-07-30 21:00 ` Andrew Burgess
2019-07-27 16:23 ` [PATCH 6/7] gdb/fortran: Add new 'info modules' command Andrew Burgess
2019-07-27 16:45 ` Eli Zaretskii
2019-07-29 20:30 ` Tom Tromey
2019-07-27 16:23 ` [PATCH 1/7] gdb: Add new -n flag to some info commands Andrew Burgess
2019-07-27 16:41 ` Eli Zaretskii
2019-07-30 21:02 ` Andrew Burgess
2019-07-31 14:51 ` Eli Zaretskii
2019-08-26 15:52 ` Andrew Burgess
2019-08-26 16:19 ` Eli Zaretskii
2019-08-27 15:27 ` Andrew Burgess
2019-08-28 15:13 ` [committed][gdb/testsuite] Fix info-var.exp for debug info from other files Tom de Vries
2019-07-29 20:23 ` [PATCH 1/7] gdb: Add new -n flag to some info commands Tom Tromey
2019-07-27 16:23 ` [PATCH 7/7] gdb: Add new commands to list module variables and functions Andrew Burgess
2019-07-27 17:06 ` Eli Zaretskii
2019-07-27 16:23 ` [PATCH 4/7] gdb/fortran: Implement la_print_typedef for Fortran Andrew Burgess
2019-08-28 12:37 ` Andrew Burgess
2019-07-27 16:23 ` [PATCH 5/7] gdb/fortran: Don't include module symbols when searching for types Andrew Burgess
2019-08-28 12:37 ` Andrew Burgess
2019-08-29 9:09 ` Tom de Vries
2019-08-29 11:45 ` Tom de Vries [this message]
2019-08-29 12:47 ` [committed][gdb/testsuite] Fix gdb.fortran/info-types.exp regexp Tom de Vries
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4aae6453-0369-0d35-8638-196732a9ad4f@suse.de \
--to=tdevries@suse.de \
--cc=Richard.Bunt@arm.com \
--cc=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox