From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 66216 invoked by alias); 29 Aug 2019 11:45:36 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 66157 invoked by uid 89); 29 Aug 2019 11:45:36 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-13.3 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: mx1.suse.de Received: from mx2.suse.de (HELO mx1.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 29 Aug 2019 11:45:35 +0000 Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id B8B64AE9A; Thu, 29 Aug 2019 11:45:32 +0000 (UTC) Subject: Re: [PATCH 5/7] gdb/fortran: Don't include module symbols when searching for types From: Tom de Vries To: Andrew Burgess , gdb-patches@sourceware.org Cc: Richard Bunt References: <5184ae288c08432d0e873fd48b8c56619e3d2699.1564243858.git.andrew.burgess@embecosm.com> <20190828123722.GW6076@embecosm.com> <557e551b-62a8-b501-1f6a-c9569dfb4031@suse.de> Openpgp: preference=signencrypt Message-ID: <4aae6453-0369-0d35-8638-196732a9ad4f@suse.de> Date: Thu, 29 Aug 2019 11:45:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <557e551b-62a8-b501-1f6a-c9569dfb4031@suse.de> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2019-08/txt/msg00641.txt.bz2 On 29-08-19 11:09, Tom de Vries wrote: > On 28-08-19 14:37, Andrew Burgess wrote: >> * Andrew Burgess [2019-07-27 17:22:33 +0100]: >> >>> Currently the 'info types' command will return symbols that correspond >>> to Fortran modules. This because the symbols are created with domain >>> MODULE_DOMAIN, but address_class LOC_TYPEDEF, which is the same >>> address_class as type symbols. >>> >>> This commit explicitly prevents MODULE_DOMAIN symbols from appearing >>> when we search for symbols in the TYPES_DOMAIN, this prevents the >>> module symbols from appearing in the output of 'info types'. >>> >>> gdb/ChangeLog: >>> >>> * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols >>> when searching for types. >>> >>> gdb/testsuite/ChangeLog: >>> >>> * gdb.fortran/info-types.exp: Add module. >>> * gdb.fortran/info-types.f90: Update expected results. >> >> I've now pushed this patch as it only depended on the previous patch >> in this series. > > Also, this test-case times out with check-read1, due to the many > "Non-debugging symbols" that are parsed by a single .*. Sorry, wrong thread, this is about gdb.base/info-var.exp: ... FAIL: gdb.base/info-var.exp: info variables (timeout) FAIL: gdb.base/info-var.exp: info variables -n (timeout) FAIL: gdb.base/info-var.exp: info variables -n global (timeout) ... Thanks, - Tom