From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 90470 invoked by alias); 27 Jul 2019 16:41:15 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 90462 invoked by uid 89); 27 Jul 2019 16:41:15 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-10.9 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (209.51.188.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 27 Jul 2019 16:41:14 +0000 Received: from fencepost.gnu.org ([2001:470:142:3::e]:42742) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hrPku-00052q-6B; Sat, 27 Jul 2019 12:41:12 -0400 Received: from [176.228.60.248] (port=3983 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hrPkt-000766-DL; Sat, 27 Jul 2019 12:41:11 -0400 Date: Sat, 27 Jul 2019 16:41:00 -0000 Message-Id: <83o91fl9b9.fsf@gnu.org> From: Eli Zaretskii To: Andrew Burgess CC: gdb-patches@sourceware.org, Richard.Bunt@arm.com In-reply-to: (message from Andrew Burgess on Sat, 27 Jul 2019 17:22:29 +0100) Subject: Re: [PATCH 1/7] gdb: Add new -n flag to some info commands References: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-IsSubscribed: yes X-SW-Source: 2019-07/txt/msg00616.txt.bz2 > From: Andrew Burgess > Cc: Richard Bunt , Andrew Burgess > Date: Sat, 27 Jul 2019 17:22:29 +0100 > > index cc1d58520d4..40b56727227 100644 > --- a/gdb/NEWS > +++ b/gdb/NEWS > @@ -215,6 +215,10 @@ maint show test-options-completion-result > printing of some header information in a similar fashion to "info > variables" and "info functions". > > + ** The "info variables", "info functions", and "whereis" commands > + now take a '-n' flag that excludes non-debug symbols from the > + results. I'm afraid "non-debug symbols" will not be self-explanatory enough. Can we say something more concrete here, or at least give a couple of examples? > +By default, the command will include non-debug symbols in the output\n\ > +these can be excluded using the -n flag." : "")); I believe we need a semi-colon after "output". > +Non-debug symbols are also included in the results if the symbols are > +of a type that indicates they might be for executable code. The > +@samp{-n} flag excludes non-debugging symbols from the results. Please add here text that explains what are "non-debug symbols". I also had difficulty understanding what does "a type that indicates they might be for executable code" means, so maybe clarify that as well. > @@ -18587,11 +18591,15 @@ > language of the variable, other values mean to use > the manually specified language (see @ref{Manually, ,Set Language Manually}). > > +Non-debug symbols are also included in the results if the symbols are > +of a type that indicates they might be for data objects. The > +@samp{-n} flag excludes non-debugging symbols from the results. Same here. Thanks.