From: Eli Zaretskii <eliz@gnu.org>
To: Doug Evans <dje@google.com>
Cc: tromey@redhat.com, gdb-patches@sourceware.org
Subject: Re: [RFA] Add -s option to source command.
Date: Fri, 09 Apr 2010 19:31:00 -0000 [thread overview]
Message-ID: <83iq80zali.fsf@gnu.org> (raw)
In-Reply-To: <m2ve394668d1004091112t322e9f1ex44a294f7b7e6a275@mail.gmail.com>
> Date: Fri, 9 Apr 2010 11:12:27 -0700
> From: Doug Evans <dje@google.com>
> Cc: tromey@redhat.com, gdb-patches@sourceware.org
>
> > This is fine, but what if @var{filename} is @file{d:/foo/myscript} (on
> > Windows)?
>
> source.c:openp() doesn't handle that case, it just blindly concatenates.
> [presumably because it hasn't needed to]
>
> I don't have an opinion on what *should* happen here.
> Possibilities are to either not try or remove the drive spec.
My vote is for removing the drive letter. The other alternative means
that absolute file names are handled inconsistently across platforms
(I assume that not trying to look for absolute file name on Posix
platforms will not be a useful behavior).
next prev parent reply other threads:[~2010-04-09 19:31 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-06 21:58 Doug Evans
2010-04-06 23:17 ` Doug Evans
2010-04-07 20:14 ` Tom Tromey
2010-04-08 22:49 ` Doug Evans
2010-04-08 23:09 ` Sergio Durigan Junior
2010-04-09 0:13 ` Doug Evans
2010-04-09 17:15 ` Tom Tromey
2010-04-09 17:48 ` Eli Zaretskii
2010-04-10 1:29 ` Joel Brobecker
2010-04-09 7:49 ` Eli Zaretskii
2010-04-09 17:23 ` Doug Evans
2010-04-09 17:46 ` Eli Zaretskii
2010-04-09 18:12 ` Doug Evans
2010-04-09 19:31 ` Eli Zaretskii [this message]
2010-04-09 19:49 ` Doug Evans
2010-04-12 17:31 ` Doug Evans
2010-04-12 17:33 ` Doug Evans
2010-04-12 17:47 ` Tom Tromey
2010-04-12 17:54 ` Eli Zaretskii
2010-04-14 22:01 ` Doug Evans
2010-04-15 3:10 ` Eli Zaretskii
2010-04-09 17:13 ` Tom Tromey
2010-04-09 17:15 ` Doug Evans
2010-04-09 17:19 ` Tom Tromey
2010-04-17 15:20 ` H.J. Lu
2010-04-20 5:38 ` Doug Evans
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83iq80zali.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox