From: Eli Zaretskii <eliz@gnu.org>
To: Doug Evans <dje@google.com>
Cc: tromey@redhat.com, gdb-patches@sourceware.org
Subject: Re: [RFA] Add -s option to source command.
Date: Fri, 09 Apr 2010 07:49:00 -0000 [thread overview]
Message-ID: <8339z512xz.fsf@gnu.org> (raw)
In-Reply-To: <i2we394668d1004081549oede200ddkf7c8c51dde0dd8b1@mail.gmail.com>
> Date: Thu, 8 Apr 2010 15:49:41 -0700
> From: Doug Evans <dje@google.com>
> Cc: gdb-patches@sourceware.org
>
>
> --- NEWS 1 Apr 2010 14:11:22 -0000 1.367
> +++ NEWS 8 Apr 2010 22:40:59 -0000
> @@ -3,6 +3,10 @@
>
> *** Changes since GDB 7.1
>
> +* The source command now accepts a -s option to force searching for the
> + script in the source search path even if the script name specifies
> + a directory.
> +
This part is okay.
> --- doc/gdb.texinfo 8 Apr 2010 21:08:40 -0000 1.697
> +++ doc/gdb.texinfo 8 Apr 2010 22:41:00 -0000
This part is okay, with a couple of comments:
> @@ -19373,7 +19373,7 @@ using the @code{script-extension} settin
> @table @code
> @kindex source
> @cindex execute commands from a file
> -@item source [@code{-v}] @var{filename}
> +@item source [@code{-s}] [@code{-v}] @var{filename}
Please remove the @code markup from the switches, it is redundant
(because this is "@table @code" already, so every @item gets the @code
markup by default). Yes, the old text was also wrong.
> +If @code{-s} is specified, then @value{GDBN} searches for @var{filename}
> +on the search path even if @var{filename} specifies a directory.
I presume it searches for the basename of @var{filename}, right? If
so, please tell that explicitly. Also, the comments in the
implementation say that symlinks are not resolved; if that's how we
want this to work, it should also be mentioned, I think.
Thanks.
next prev parent reply other threads:[~2010-04-09 7:49 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-06 21:58 Doug Evans
2010-04-06 23:17 ` Doug Evans
2010-04-07 20:14 ` Tom Tromey
2010-04-08 22:49 ` Doug Evans
2010-04-08 23:09 ` Sergio Durigan Junior
2010-04-09 0:13 ` Doug Evans
2010-04-09 17:15 ` Tom Tromey
2010-04-09 17:48 ` Eli Zaretskii
2010-04-10 1:29 ` Joel Brobecker
2010-04-09 7:49 ` Eli Zaretskii [this message]
2010-04-09 17:23 ` Doug Evans
2010-04-09 17:46 ` Eli Zaretskii
2010-04-09 18:12 ` Doug Evans
2010-04-09 19:31 ` Eli Zaretskii
2010-04-09 19:49 ` Doug Evans
2010-04-12 17:31 ` Doug Evans
2010-04-12 17:33 ` Doug Evans
2010-04-12 17:47 ` Tom Tromey
2010-04-12 17:54 ` Eli Zaretskii
2010-04-14 22:01 ` Doug Evans
2010-04-15 3:10 ` Eli Zaretskii
2010-04-09 17:13 ` Tom Tromey
2010-04-09 17:15 ` Doug Evans
2010-04-09 17:19 ` Tom Tromey
2010-04-17 15:20 ` H.J. Lu
2010-04-20 5:38 ` Doug Evans
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8339z512xz.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox