From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-71904-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 28573 invoked by alias); 9 Apr 2010 07:49:44 -0000
Received: (qmail 28540 invoked by uid 22791); 9 Apr 2010 07:49:41 -0000
X-SWARE-Spam-Status: No, hits=-1.2 required=5.0 	tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL
X-Spam-Check-By: sourceware.org
Received: from mtaout21.012.net.il (HELO mtaout21.012.net.il) (80.179.55.169)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 09 Apr 2010 07:49:31 +0000
Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0L0L00H00MZJ6900@a-mtaout21.012.net.il> for gdb-patches@sourceware.org; Fri, 09 Apr 2010 10:48:39 +0300 (IDT)
Received: from HOME-C4E4A596F7 ([77.124.92.42]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0L0L00H05N127G00@a-mtaout21.012.net.il>; Fri, 09 Apr 2010 10:48:39 +0300 (IDT)
Date: Fri, 09 Apr 2010 07:49:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [RFA] Add -s option to source command.
In-reply-to: <i2we394668d1004081549oede200ddkf7c8c51dde0dd8b1@mail.gmail.com>
To: Doug Evans <dje@google.com>
Cc: tromey@redhat.com, gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <8339z512xz.fsf@gnu.org>
References: <20100406215751.7EC1784397@ruffy.mtv.corp.google.com> <m3fx37uija.fsf@fleche.redhat.com> <i2we394668d1004081549oede200ddkf7c8c51dde0dd8b1@mail.gmail.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-04/txt/msg00223.txt.bz2

> Date: Thu, 8 Apr 2010 15:49:41 -0700
> From: Doug Evans <dje@google.com>
> Cc: gdb-patches@sourceware.org
> 
> 
> --- NEWS	1 Apr 2010 14:11:22 -0000	1.367
> +++ NEWS	8 Apr 2010 22:40:59 -0000
> @@ -3,6 +3,10 @@
>  
>  *** Changes since GDB 7.1
>  
> +* The source command now accepts a -s option to force searching for the
> +  script in the source search path even if the script name specifies
> +  a directory.
> +

This part is okay.

> --- doc/gdb.texinfo	8 Apr 2010 21:08:40 -0000	1.697
> +++ doc/gdb.texinfo	8 Apr 2010 22:41:00 -0000

This part is okay, with a couple of comments:

> @@ -19373,7 +19373,7 @@ using the @code{script-extension} settin
>  @table @code
>  @kindex source
>  @cindex execute commands from a file
> -@item source [@code{-v}] @var{filename}
> +@item source [@code{-s}] [@code{-v}] @var{filename}

Please remove the @code markup from the switches, it is redundant
(because this is "@table @code" already, so every @item gets the @code
markup by default).  Yes, the old text was also wrong.

> +If @code{-s} is specified, then @value{GDBN} searches for @var{filename}
> +on the search path even if @var{filename} specifies a directory.

I presume it searches for the basename of @var{filename}, right?  If
so, please tell that explicitly.  Also, the comments in the
implementation say that symlinks are not resolved; if that's how we
want this to work, it should also be mentioned, I think.

Thanks.