Re: [RFA] Add -s option to source command.

[Doug Evans <dje@google.com>]

On Fri, Apr 9, 2010 at 12:31 PM, Eli Zaretskii <eliz@gnu.org> wrote:
>> Date: Fri, 9 Apr 2010 11:12:27 -0700
>> From: Doug Evans <dje@google.com>
>> Cc: tromey@redhat.com, gdb-patches@sourceware.org
>>
>> > This is fine, but what if @var{filename} is @file{d:/foo/myscript} (on
>> > Windows)?
>>
>> source.c:openp() doesn't handle that case, it just blindly concatenates.
>> [presumably because it hasn't needed to]
>>
>> I don't have an opinion on what *should* happen here.
>> Possibilities are to either not try or remove the drive spec.
>
> My vote is for removing the drive letter.  The other alternative means
> that absolute file names are handled inconsistently across platforms
> (I assume that not trying to look for absolute file name on Posix
> platforms will not be a useful behavior).
>

I can make a case for either choice on Posix platforms: ie. whether to
search or to not search.  I don't know which is better, but openp()
already does the search for absolute path names (if
OPF_SEARCH_IN_PATH is specified), so I lean towards not introducing
something new.

Does anyone know if there's existing code to strip a drive letter if present?
[It's trivial to do - but I fear the discussion involved in getting a
patch in that does it The Right Way.]