From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-71958-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 8991 invoked by alias); 9 Apr 2010 19:31:44 -0000
Received: (qmail 8982 invoked by uid 22791); 9 Apr 2010 19:31:44 -0000
X-SWARE-Spam-Status: No, hits=-1.2 required=5.0 	tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL
X-Spam-Check-By: sourceware.org
Received: from mtaout21.012.net.il (HELO mtaout21.012.net.il) (80.179.55.169)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 09 Apr 2010 19:31:39 +0000
Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0L0M00H00JJGB700@a-mtaout21.012.net.il> for gdb-patches@sourceware.org; Fri, 09 Apr 2010 22:31:35 +0300 (IDT)
Received: from HOME-C4E4A596F7 ([77.124.92.42]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0L0M00FPLJKNUL60@a-mtaout21.012.net.il>; Fri, 09 Apr 2010 22:31:35 +0300 (IDT)
Date: Fri, 09 Apr 2010 19:31:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [RFA] Add -s option to source command.
In-reply-to: <m2ve394668d1004091112t322e9f1ex44a294f7b7e6a275@mail.gmail.com>
To: Doug Evans <dje@google.com>
Cc: tromey@redhat.com, gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83iq80zali.fsf@gnu.org>
References: <20100406215751.7EC1784397@ruffy.mtv.corp.google.com> <m3fx37uija.fsf@fleche.redhat.com> <i2we394668d1004081549oede200ddkf7c8c51dde0dd8b1@mail.gmail.com> <8339z512xz.fsf@gnu.org> <s2oe394668d1004091023s8f2e484fq42d17ca1b0709860@mail.gmail.com> <83mxxczfha.fsf@gnu.org> <m2ve394668d1004091112t322e9f1ex44a294f7b7e6a275@mail.gmail.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-04/txt/msg00277.txt.bz2

> Date: Fri, 9 Apr 2010 11:12:27 -0700
> From: Doug Evans <dje@google.com>
> Cc: tromey@redhat.com, gdb-patches@sourceware.org
> 
> > This is fine, but what if @var{filename} is @file{d:/foo/myscript} (on
> > Windows)?
> 
> source.c:openp() doesn't handle that case, it just blindly concatenates.
> [presumably because it hasn't needed to]
> 
> I don't have an opinion on what *should* happen here.
> Possibilities are to either not try or remove the drive spec.

My vote is for removing the drive letter.  The other alternative means
that absolute file names are handled inconsistently across platforms
(I assume that not trying to look for absolute file name on Posix
platforms will not be a useful behavior).