From: Eli Zaretskii <eliz@gnu.org>
To: Gary Benson <gbenson@redhat.com>
Cc: gdb-patches@sourceware.org, simon.marchi@ericsson.com, palves@redhat.com
Subject: Re: [PATCH v2] linux: Add maintenance commands to test libthread_db
Date: Tue, 05 Jun 2018 16:11:00 -0000 [thread overview]
Message-ID: <83h8mh9psa.fsf@gnu.org> (raw)
In-Reply-To: <20180605154612.GA30767@blade.nx> (message from Gary Benson on Tue, 5 Jun 2018 16:46:13 +0100)
> Date: Tue, 5 Jun 2018 16:46:13 +0100
> From: Gary Benson <gbenson@redhat.com>
> Cc: gdb-patches@sourceware.org, simon.marchi@ericsson.com,
> palves@redhat.com
>
> > I think some of this text should be in the manual, otherwise the
> > description of the command is not very useful.
>
> How about this, as the full diff of the manual? I added the text to
> the first section, and updated the second to point at the first and
> also to document what happens when automated tests fail.
Thanks, this is very good. I have a couple of minor comments:
> +@kindex maint check libthread-db
> +@item maint check libthread-db
> +Run integrity checks on the current inferior's thread debugging
> +library. This exercises all libthread_db functionality used by GDB on
"libthread_db" should be in @code or in @file. And please use
@value{GDBN} instead of a literal "GDB".
> +GNU/Linux systems, and by extension also exercises the proc_service
proc_service should be in @code.
next prev parent reply other threads:[~2018-06-05 16:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-22 14:42 [PATCH] " Gary Benson
2017-11-22 19:31 ` Simon Marchi
2017-11-23 13:22 ` Pedro Alves
2018-05-23 18:57 ` [PATCH v2] " Gary Benson
2018-05-23 19:21 ` Eli Zaretskii
2018-06-05 15:46 ` Gary Benson
2018-06-05 16:11 ` Eli Zaretskii [this message]
2018-05-24 14:10 ` Simon Marchi
2018-06-05 16:31 ` Pedro Alves
2018-06-08 17:25 ` [PATCH v3/pushed] " Gary Benson
2018-06-11 17:15 ` [PATCH] Fix ref in gdb.texinfo Szabolcs Nagy
2018-06-11 17:32 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83h8mh9psa.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gbenson@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=simon.marchi@ericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox