Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Gary Benson <gbenson@redhat.com>, gdb-patches@sourceware.org
Cc: Simon Marchi <simon.marchi@ericsson.com>
Subject: Re: [PATCH v2] linux: Add maintenance commands to test libthread_db
Date: Tue, 05 Jun 2018 16:31:00 -0000	[thread overview]
Message-ID: <20074994-70c2-151c-95c3-5c0090a87bd8@redhat.com> (raw)
In-Reply-To: <1527096776-29187-1-git-send-email-gbenson@redhat.com>

Hi Gary,

On 05/23/2018 06:32 PM, Gary Benson wrote:

> Ok to commit?

This looks good to me too, except one thing.  I think
you end up with duplicated test messages:

  https://sourceware.org/gdb/wiki/GDBTestcaseCookbook#Make_sure_test_messages_are_unique

I suggestwrapping the several phases of the testcase in with_test_prefix
or proc_with_prefix.  Something like:

# Manual check with NPTL fully operational.

with_test_prefix "manual fully op" {
   ...
}

# Automated check with NPTL uninitialized.

with_test_prefix "automated uninitialized" {
   ...
}

etc.

OK with me with that change.

Thanks,
Pedro Alves


  parent reply	other threads:[~2018-06-05 16:31 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-22 14:42 [PATCH] " Gary Benson
2017-11-22 19:31 ` Simon Marchi
2017-11-23 13:22 ` Pedro Alves
2018-05-23 18:57 ` [PATCH v2] " Gary Benson
2018-05-23 19:21   ` Eli Zaretskii
2018-06-05 15:46     ` Gary Benson
2018-06-05 16:11       ` Eli Zaretskii
2018-05-24 14:10   ` Simon Marchi
2018-06-05 16:31   ` Pedro Alves [this message]
2018-06-08 17:25     ` [PATCH v3/pushed] " Gary Benson
2018-06-11 17:15       ` [PATCH] Fix ref in gdb.texinfo Szabolcs Nagy
2018-06-11 17:32         ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20074994-70c2-151c-95c3-5c0090a87bd8@redhat.com \
    --to=palves@redhat.com \
    --cc=gbenson@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=simon.marchi@ericsson.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox