Re: [PATCH v2] linux: Add maintenance commands to test libthread_db

[Eli Zaretskii <eliz@gnu.org>]

> From: Gary Benson <gbenson@redhat.com>
> Cc: Simon Marchi <simon.marchi@ericsson.com>,	Pedro Alves <palves@redhat.com>
> Date: Wed, 23 May 2018 18:32:56 +0100
> 
> The test itself is a basic integrity check exercising all libthread_db
> functions used by GDB on GNU/Linux systems.  By extension this also
> exercises the proc_service functions provided by GDB that libthread_db
> uses.  This is useful for NPTL developers and libthread_db developers.
> It could also prove useful investigating bugs reported against GDB
> where the thread debugging library or GDB's proc_service layer is
> suspect.

I think some of this text should be in the manual, otherwise the
description of the command is not very useful.

> diff --git a/gdb/NEWS b/gdb/NEWS
> index cef5580..2e6cb74 100644
> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -27,6 +27,16 @@ set|show record btrace cpu
>    Controls the processor to be used for enabling errata workarounds for
>    branch trace decode.
>  
> +maint check libthread-db
> +  Run integrity checks on the current inferior's thread debugging
> +  library
> +
> +maint set check-libthread-db (on|off)
> +maint show check-libthread-db
> +  Control whether to run integrity checks on inferior specific thread
> +  debugging libraries as they are loaded.  The default is not to
> +  perform such checks.
> +
>  * Python API

This part is OK.

> diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
> index 28f083f..6faaabe 100644
> --- a/gdb/doc/gdb.texinfo
> +++ b/gdb/doc/gdb.texinfo
> @@ -35533,6 +35533,11 @@ modify XML target descriptions.
>  Check that the target descriptions dynamically created by @value{GDBN}
>  equal the descriptions created from XML files found in @var{dir}.
>  
> +@kindex maint check libthread-db
> +@item maint check libthread-db
> +Run integrity checks on the current inferior's thread debugging
> +library.
> +
>  @kindex maint print dummy-frames
>  @item maint print dummy-frames
>  Prints the contents of @value{GDBN}'s internal dummy-frame stack.
> @@ -35840,6 +35845,14 @@ number of blocks in the blockvector
>  @end enumerate
>  @end table
>  
> +@kindex maint set check-libthread-db
> +@kindex maint show check-libthread-db
> +@item maint set check-libthread-db [on|off]
> +@itemx maint show check-libthread-db
> +Control whether @value{GDBN} should run integrity checks on inferior
> +specific thread debugging libraries as they are loaded.  The default
> +is not to perform such checks.
> +

This is also OK, modulo the request to expand the description.

Thanks.