From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-147957-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 121163 invoked by alias); 5 Jun 2018 16:31:20 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 121105 invoked by uid 89); 5 Jun 2018 16:31:06 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS autolearn=no version=3.3.2 spammy=operational
X-HELO: mx1.redhat.com
Received: from mx3-rdu2.redhat.com (HELO mx1.redhat.com) (66.187.233.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 05 Jun 2018 16:31:05 +0000
Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5])	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))	(No client certificate requested)	by mx1.redhat.com (Postfix) with ESMTPS id B4811CB9C5;	Tue,  5 Jun 2018 16:31:03 +0000 (UTC)
Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4])	by smtp.corp.redhat.com (Postfix) with ESMTP id 1836A6B411;	Tue,  5 Jun 2018 16:31:02 +0000 (UTC)
Subject: Re: [PATCH v2] linux: Add maintenance commands to test libthread_db
To: Gary Benson <gbenson@redhat.com>, gdb-patches@sourceware.org
References: <1511361761-1333-1-git-send-email-gbenson@redhat.com> <1527096776-29187-1-git-send-email-gbenson@redhat.com>
Cc: Simon Marchi <simon.marchi@ericsson.com>
From: Pedro Alves <palves@redhat.com>
Message-ID: <20074994-70c2-151c-95c3-5c0090a87bd8@redhat.com>
Date: Tue, 05 Jun 2018 16:31:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0
MIME-Version: 1.0
In-Reply-To: <1527096776-29187-1-git-send-email-gbenson@redhat.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-SW-Source: 2018-06/txt/msg00100.txt.bz2

Hi Gary,

On 05/23/2018 06:32 PM, Gary Benson wrote:

> Ok to commit?

This looks good to me too, except one thing.  I think
you end up with duplicated test messages:

  https://sourceware.org/gdb/wiki/GDBTestcaseCookbook#Make_sure_test_messages_are_unique

I suggestwrapping the several phases of the testcase in with_test_prefix
or proc_with_prefix.  Something like:

# Manual check with NPTL fully operational.

with_test_prefix "manual fully op" {
   ...
}

# Automated check with NPTL uninitialized.

with_test_prefix "automated uninitialized" {
   ...
}

etc.

OK with me with that change.

Thanks,
Pedro Alves