From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 45554 invoked by alias); 5 Jun 2018 16:11:44 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 45484 invoked by uid 89); 5 Jun 2018 16:11:42 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-6.9 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_1,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (208.118.235.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 05 Jun 2018 16:11:41 +0000 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fQEYa-0001SL-AC for gdb-patches@sourceware.org; Tue, 05 Jun 2018 12:11:39 -0400 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:46641) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fQEYN-0001IR-PK; Tue, 05 Jun 2018 12:11:23 -0400 Received: from [176.228.60.248] (port=3980 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fQEYN-0003CN-5B; Tue, 05 Jun 2018 12:11:23 -0400 Date: Tue, 05 Jun 2018 16:11:00 -0000 Message-Id: <83h8mh9psa.fsf@gnu.org> From: Eli Zaretskii To: Gary Benson CC: gdb-patches@sourceware.org, simon.marchi@ericsson.com, palves@redhat.com In-reply-to: <20180605154612.GA30767@blade.nx> (message from Gary Benson on Tue, 5 Jun 2018 16:46:13 +0100) Subject: Re: [PATCH v2] linux: Add maintenance commands to test libthread_db Reply-to: Eli Zaretskii References: <1511361761-1333-1-git-send-email-gbenson@redhat.com> <1527096776-29187-1-git-send-email-gbenson@redhat.com> <837enuclmj.fsf@gnu.org> <20180605154612.GA30767@blade.nx> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-IsSubscribed: yes X-SW-Source: 2018-06/txt/msg00099.txt.bz2 > Date: Tue, 5 Jun 2018 16:46:13 +0100 > From: Gary Benson > Cc: gdb-patches@sourceware.org, simon.marchi@ericsson.com, > palves@redhat.com > > > I think some of this text should be in the manual, otherwise the > > description of the command is not very useful. > > How about this, as the full diff of the manual? I added the text to > the first section, and updated the second to point at the first and > also to document what happens when automated tests fail. Thanks, this is very good. I have a couple of minor comments: > +@kindex maint check libthread-db > +@item maint check libthread-db > +Run integrity checks on the current inferior's thread debugging > +library. This exercises all libthread_db functionality used by GDB on "libthread_db" should be in @code or in @file. And please use @value{GDBN} instead of a literal "GDB". > +GNU/Linux systems, and by extension also exercises the proc_service proc_service should be in @code.