Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Mike Frysinger <vapier@gentoo.org>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb: improve usage strings
Date: Sat, 11 Aug 2012 17:16:00 -0000	[thread overview]
Message-ID: <83fw7tcpst.fsf@gnu.org> (raw)
In-Reply-To: <1344704080-24677-1-git-send-email-vapier@gentoo.org>

> From: Mike Frysinger <vapier@gentoo.org>
> Date: Sat, 11 Aug 2012 12:54:40 -0400
> 
> This adds Usage strings to a bunch of commands, tweaks the grammar in a
> few, and improves the help text for the handle command.

Thanks.

>    c = add_com ("signal", class_run, signal_command, _("\
> -Continue program giving it signal specified by the argument.\n\
> -An argument of \"0\" means continue program without giving it a signal."));
> +Continue program by sending it the specified signal.\n\

This "by sending it" is AFAIU inaccurate: we don't continue program
_by_ sending it the signal, we continue the program _and_ send it the
signal.  I actually don't see anything wrong with the original
wording.

>    add_com ("finish", class_run, finish_command, _("\
>  Execute until selected stack frame returns.\n\
> +Usage: finish\n\
>  Upon return, the value returned is printed and put in the value history."));

Does this "usage" really add any information?

>    add_com ("next", class_run, next_command, _("\
>  Step program, proceeding through subroutine calls.\n\
> +Usage: next [N]\n\
>  Like the \"step\" command as long as subroutine calls do not happen;\n\
>  when they do, the call is treated as one instruction.\n\
> -Argument N means do this N times (or till program stops for another \
> +Argument N means step N times (or till program stops for another \

Isn't it better to say "N source lines"?

Btw, I find this entire doc string completely obfuscated.  How about
this instead:

  Step program until it reaches a different source line.
  Usage: next [N]
  Unlike "step", if the current source line calls a subroutine,
  this command does not enter the subroutine, but instead steps over
  the call, in effect treating it as a single source line.


  reply	other threads:[~2012-08-11 17:16 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-11 16:55 Mike Frysinger
2012-08-11 17:16 ` Eli Zaretskii [this message]
2012-08-11 17:36   ` Mike Frysinger
2012-08-11 17:52     ` Eli Zaretskii
2012-08-11 18:08       ` Mike Frysinger
2012-08-14 15:08         ` Tom Tromey
2012-08-12  5:06     ` Doug Evans
2012-08-12  5:10       ` Mike Frysinger
2012-08-12 17:35       ` Eli Zaretskii
2012-08-13  2:06 ` [PATCH v2] " Mike Frysinger
2012-08-13 20:29   ` Doug Evans
2012-08-14  5:13     ` Mike Frysinger
2012-08-23 11:11     ` Pedro Alves
2012-08-14  5:29 ` [PATCH v3] " Mike Frysinger
2012-08-14 17:34   ` Doug Evans
2012-08-14 18:10     ` Eli Zaretskii
2012-08-15  1:58       ` Mike Frysinger
2012-08-15  7:22         ` Regression for gdb.base/help.exp [Re: [PATCH v3] gdb: improve usage strings] Jan Kratochvil
2012-08-15 16:25           ` Mike Frysinger
2012-08-15 16:27             ` Doug Evans
2012-08-20  4:29             ` Sergio Durigan Junior
2012-08-17  3:06           ` Mike Frysinger
2012-08-23 16:26         ` further improve "handle" help string Pedro Alves
2012-08-23 16:44           ` Eli Zaretskii
2012-08-23 17:18           ` Mike Frysinger
2012-08-23 17:38             ` Pedro Alves
2012-08-23 11:11     ` [PATCH v3] gdb: improve usage strings Pedro Alves
2012-08-23 16:45       ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83fw7tcpst.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=vapier@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox