From: Doug Evans <dje@google.com>
To: Mike Frysinger <vapier@gentoo.org>
Cc: Eli Zaretskii <eliz@gnu.org>, gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb: improve usage strings
Date: Sun, 12 Aug 2012 05:06:00 -0000 [thread overview]
Message-ID: <CADPb22RywuYUq=4A+SZYcZj-Jq1wKmm=vfMxh8qcOgMTuK2hKw@mail.gmail.com> (raw)
In-Reply-To: <201208111336.41052.vapier@gentoo.org>
On Sat, Aug 11, 2012 at 10:36 AM, Mike Frysinger <vapier@gentoo.org> wrote:
> On Saturday 11 August 2012 13:16:18 Eli Zaretskii wrote:
>> > From: Mike Frysinger <vapier@gentoo.org>
>> > Date: Sat, 11 Aug 2012 12:54:40 -0400
>> > c = add_com ("signal", class_run, signal_command, _("\
>> >
>> > -Continue program giving it signal specified by the argument.\n\
>> > -An argument of \"0\" means continue program without giving it a
>> > signal."));
>> > +Continue program by sending it the specified signal.\n\
>>
>> This "by sending it" is AFAIU inaccurate: we don't continue program
>> _by_ sending it the signal, we continue the program _and_ send it the
>> signal. I actually don't see anything wrong with the original
>> wording.
>
> ok, but your response shows what i was trying to fix:
> - adding "the" before "program"
> - changing "giving" to "sending"
> the "by" change was incidental
>
> so i'll change it to:
> Continue program and send it the specified signal.
fwiw, I'm not comfortable with that wording.
To the naive user it's not clear (IMO) that the program is resumed
with the specified signal, i.e., I can imagine the user wondering if
there's a gap between when the target is resumed and when the signal
is delivered.
Do we have a target where there can be a delay? (e.g, the figurative
equivalent of "continue &; kill SIGNAL)?
Given that, I like something along the lines of "Continue program by
sending it the specified signal."
next prev parent reply other threads:[~2012-08-12 5:06 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-11 16:55 Mike Frysinger
2012-08-11 17:16 ` Eli Zaretskii
2012-08-11 17:36 ` Mike Frysinger
2012-08-11 17:52 ` Eli Zaretskii
2012-08-11 18:08 ` Mike Frysinger
2012-08-14 15:08 ` Tom Tromey
2012-08-12 5:06 ` Doug Evans [this message]
2012-08-12 5:10 ` Mike Frysinger
2012-08-12 17:35 ` Eli Zaretskii
2012-08-13 2:06 ` [PATCH v2] " Mike Frysinger
2012-08-13 20:29 ` Doug Evans
2012-08-14 5:13 ` Mike Frysinger
2012-08-23 11:11 ` Pedro Alves
2012-08-14 5:29 ` [PATCH v3] " Mike Frysinger
2012-08-14 17:34 ` Doug Evans
2012-08-14 18:10 ` Eli Zaretskii
2012-08-15 1:58 ` Mike Frysinger
2012-08-15 7:22 ` Regression for gdb.base/help.exp [Re: [PATCH v3] gdb: improve usage strings] Jan Kratochvil
2012-08-15 16:25 ` Mike Frysinger
2012-08-15 16:27 ` Doug Evans
2012-08-20 4:29 ` Sergio Durigan Junior
2012-08-17 3:06 ` Mike Frysinger
2012-08-23 16:26 ` further improve "handle" help string Pedro Alves
2012-08-23 16:44 ` Eli Zaretskii
2012-08-23 17:18 ` Mike Frysinger
2012-08-23 17:38 ` Pedro Alves
2012-08-23 11:11 ` [PATCH v3] gdb: improve usage strings Pedro Alves
2012-08-23 16:45 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADPb22RywuYUq=4A+SZYcZj-Jq1wKmm=vfMxh8qcOgMTuK2hKw@mail.gmail.com' \
--to=dje@google.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox