Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Paul Pluzhnikov <ppluzhnikov@google.com>
Cc: tromey@redhat.com, gdb-patches@sourceware.org
Subject: Re: [RFC][patch] Make DCACHE_LINE runtime-settable
Date: Mon, 25 Jul 2011 20:22:00 -0000	[thread overview]
Message-ID: <83bowif96z.fsf@gnu.org> (raw)
In-Reply-To: <CALoOobOyyOOBKBOy97se2jcnpWMwQ00_Q9ht775NiAed-HxEsA@mail.gmail.com>

> From: Paul Pluzhnikov <ppluzhnikov@google.com>
> Date: Mon, 25 Jul 2011 11:32:51 -0700
> Cc: gdb-patches@sourceware.org
> 
> +* Dcache size (number of lines) and line-size are now runtime-configurable.

Please mention the names of the new commands.

> +@item set dcache size @var{size}
> +@cindex dcache size
> +@kindex dcache size

@kindex should say "set dcache size", because @kindex entries are
commands.  Same in other commands you introduced.

> +@item show dcache size
> +@cindex dcache size
> +@kindex dcache size

It's not useful to have identical index entries pointing to the same
page.  Please remove the second instance.

> +Show maximum number of dcache entries. See also @ref{Caching Remote Data, info dcache}.
                                        ^^
Two spaces.

> +@cindex dcache line-size
> +@kindex dcache line-size
> +Show default size of dcache lines. See also @ref{Caching Remote Data, info dcache}.

Same here (both the second index entry and whitespace between
sentences).

OK with those changes.

Thanks.


  parent reply	other threads:[~2011-07-25 19:32 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-23  2:40 Paul Pluzhnikov
2011-07-23 16:57 ` Eli Zaretskii
2011-07-25 15:01 ` Tom Tromey
2011-07-25 18:47   ` Paul Pluzhnikov
2011-07-25 19:22     ` Tom Tromey
2011-07-25 19:32     ` Pedro Alves
2011-07-25 19:33       ` Tom Tromey
2011-07-25 20:49         ` Pedro Alves
2011-07-25 20:22     ` Eli Zaretskii [this message]
2011-07-25 21:04       ` Paul Pluzhnikov
2011-07-26  0:28         ` Pedro Alves
2011-07-26  9:51         ` Eli Zaretskii
2011-07-25 19:26 ` Jan Kratochvil
2011-07-25 20:58   ` Paul Pluzhnikov
2011-07-26  2:55     ` Jan Kratochvil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83bowif96z.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=ppluzhnikov@google.com \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox