Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: ppluzhnikov@google.com (Paul Pluzhnikov)
Cc: gdb-patches@sourceware.org, ppluzhnikov@google.com
Subject: Re: [RFC][patch] Make DCACHE_LINE runtime-settable
Date: Sat, 23 Jul 2011 16:57:00 -0000	[thread overview]
Message-ID: <8362mtea56.fsf@gnu.org> (raw)
In-Reply-To: <20110722222025.ED9B6190B14@elbrus2.mtv.corp.google.com>

> Cc: ppluzhnikov@google.com
> Date: Fri, 22 Jul 2011 15:20:25 -0700 (PDT)
> From: ppluzhnikov@google.com (Paul Pluzhnikov)
> 
> Attached patch allows the user to e.g. "set dcache-line-size 4096" and
> drastically reduce the number of round trips.
> 
> I've also added "set dcache-size" just for good measure.
> 
> Not sure whether this needs documentation updates.

It does.  Every command and settable option should be documented in
the manual.  We also add to NEWS a short notice of each such addition.

Thanks.

> +  add_setshow_uinteger_cmd ("dcache-line-size", class_obscure,
> +			    &dcache_line_size, _("\
> +Set dcache line size (in bytes, must be power of 2)."), _("\

You cannot have a comma in the first line of a command's doc string.
That's because commands that show only that first line, like "help"
and "apropos", will stop at the first comma.  See
cli-decode.c:print_doc_line.


  reply	other threads:[~2011-07-23  7:20 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-23  2:40 Paul Pluzhnikov
2011-07-23 16:57 ` Eli Zaretskii [this message]
2011-07-25 15:01 ` Tom Tromey
2011-07-25 18:47   ` Paul Pluzhnikov
2011-07-25 19:22     ` Tom Tromey
2011-07-25 19:32     ` Pedro Alves
2011-07-25 19:33       ` Tom Tromey
2011-07-25 20:49         ` Pedro Alves
2011-07-25 20:22     ` Eli Zaretskii
2011-07-25 21:04       ` Paul Pluzhnikov
2011-07-26  0:28         ` Pedro Alves
2011-07-26  9:51         ` Eli Zaretskii
2011-07-25 19:26 ` Jan Kratochvil
2011-07-25 20:58   ` Paul Pluzhnikov
2011-07-26  2:55     ` Jan Kratochvil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8362mtea56.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=ppluzhnikov@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox