From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18066 invoked by alias); 23 Jul 2011 07:20:18 -0000 Received: (qmail 18052 invoked by uid 22791); 23 Jul 2011 07:20:16 -0000 X-SWARE-Spam-Status: No, hits=-1.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL X-Spam-Check-By: sourceware.org Received: from mtaout22.012.net.il (HELO mtaout22.012.net.il) (80.179.55.172) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 23 Jul 2011 07:20:02 +0000 Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0LOR00400YYW7I00@a-mtaout22.012.net.il> for gdb-patches@sourceware.org; Sat, 23 Jul 2011 10:20:00 +0300 (IDT) Received: from HOME-C4E4A596F7 ([84.228.255.122]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LOR0036TZ1BN9B0@a-mtaout22.012.net.il>; Sat, 23 Jul 2011 10:20:00 +0300 (IDT) Date: Sat, 23 Jul 2011 16:57:00 -0000 From: Eli Zaretskii Subject: Re: [RFC][patch] Make DCACHE_LINE runtime-settable In-reply-to: <20110722222025.ED9B6190B14@elbrus2.mtv.corp.google.com> To: ppluzhnikov@google.com (Paul Pluzhnikov) Cc: gdb-patches@sourceware.org, ppluzhnikov@google.com Reply-to: Eli Zaretskii Message-id: <8362mtea56.fsf@gnu.org> References: <20110722222025.ED9B6190B14@elbrus2.mtv.corp.google.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-07/txt/msg00651.txt.bz2 > Cc: ppluzhnikov@google.com > Date: Fri, 22 Jul 2011 15:20:25 -0700 (PDT) > From: ppluzhnikov@google.com (Paul Pluzhnikov) > > Attached patch allows the user to e.g. "set dcache-line-size 4096" and > drastically reduce the number of round trips. > > I've also added "set dcache-size" just for good measure. > > Not sure whether this needs documentation updates. It does. Every command and settable option should be documented in the manual. We also add to NEWS a short notice of each such addition. Thanks. > + add_setshow_uinteger_cmd ("dcache-line-size", class_obscure, > + &dcache_line_size, _("\ > +Set dcache line size (in bytes, must be power of 2)."), _("\ You cannot have a comma in the first line of a command's doc string. That's because commands that show only that first line, like "help" and "apropos", will stop at the first comma. See cli-decode.c:print_doc_line.